Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching recipes and smelting #278

Open
Madis0 opened this issue Oct 1, 2021 · 5 comments
Open

Caching recipes and smelting #278

Madis0 opened this issue Oct 1, 2021 · 5 comments
Labels
T-enhancement Type: Enhancement

Comments

@Madis0
Copy link

Madis0 commented Oct 1, 2021

Is your feature request related to a problem? Please describe.
I have seen some mods for Fabric that attempt to cache the crafting recipes and smelting process. I would like to know if that kind of feature is being considered in Lithium as well and if not, why.

Describe the solution you'd like
A feature that would cache crafting recipes and smelting process

Describe alternatives you've considered
Mods Recipe Cache, Fast Furnace, FastBench

Additional context
I don't really know if this would be a good idea overall, hence I suggested it here so people relevant to game optimization can comment on it.

@2No2Name
Copy link
Member

2No2Name commented Oct 1, 2021

These mods have a nice optimization, which I believe also fits into lithium.
However we do not want to eat other mods unless the authors themselves suggest it, because the authors might not like that, even though they chose a permissive license.

@Madis0
Copy link
Author

Madis0 commented Oct 1, 2021

However we do not want to eat other mods unless the authors themselves suggest it, because the authors might not like that, even though they chose a permissive license.

I did not quite mean bundling the mods, more of just rebuilding the feature.
And my concerns were reliability (server-client sync) and sustainability (breaking with releases) of doing those changes in vanilla overall, could you or another contributor do a technical overview on that? Asking it here as you do seem to be familiar with the internals of the game.

@ghost
Copy link

ghost commented Oct 5, 2021

I am for adding this function
Since multiple installed mods work better
than 100 mods

@BobVarioa
Copy link

Even though this mod is a forge one, this could be a valuable resource while implementing this: FastSuite

@williewillus
Copy link

williewillus commented Nov 21, 2022

Note that vanilla has added a last-used-recipe cache to the furnace and the campfire, so this might not be needed anymore in those cases, unless there's optimizations that can be done on top of their cache. See e.g. AbstractFurnaceBlockEntity#quickCheck (mojmap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants