Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Exempt repository admins from branch ruleset merge requirements #1790

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 21, 2024 · 1 comment · Fixed by #1791
Closed
3 tasks done

🐛 Bug: Exempt repository admins from branch ruleset merge requirements #1790

JoshuaKGoldberg opened this issue Dec 21, 2024 · 1 comment · Fixed by #1791
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Back before #1309 -> #1788, when branch protections were set, they exempted repository admins -e.g. me on this repo- from being blocked on merging. I would expect that to remain the same.

Actual

After #1788, repo admins are blocked too.

Additional Info

I'd wanted to set this intentionally at first to make things more strict. Strictness good!

I was hoping the UI would make it easier for admins to bypass. But no, there's just ... nothing on there I can see. I'd planned on trying this out for longer but it's really annoying. Ah well.

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 21, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 21, 2024
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Dec 21, 2024 •
edited
Loading

Ah, now I remember. bypass_actors requires an actor_id when setting a "RepositoryRule". Looking the value assigned to Repository admin in few of my repositories:

So, ah, I think it's 5? But docs would be good.

Edit: filed github/rest-api-description#4406 for docs.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 21, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 21, 2024
@JoshuaKGoldberg
fix: bypass repository admin (id 5) in branch ruleset (#1791)
480c75d 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1790
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Pending being told contrary information, hardcodes `actor_id: 5` for the
repository role to always be allowed to bypass branch protection
ruleset.

💖
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bypass repository admin (id 5) in branch ruleset JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg