Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] changes for HolidayCalendarCache #34

Open
felipenoris opened this issue Dec 19, 2018 · 0 comments
Open

[Breaking] changes for HolidayCalendarCache #34

felipenoris opened this issue Dec 19, 2018 · 0 comments
Assignees
Milestone

Comments

@felipenoris
Copy link
Collaborator

Inspired by the job done at https://github.com/felipenoris/bdays, I'm planning a major breaking change for how cache works in this package.

Planned changes:

  • BusinessDays.initcache will be removed

  • BusinessDays.HolidayCalendarCache will be a subtype of BusinessDays.HolidayCalendar

Collateral effects:

  • These changes imply that bdays(:calendar_symbol, d0, d1 method won't work for cached calendars anymore. The user will need to pass an instance of HolidayCalendarCache.

  • internal package state variable BusinessDays. CACHE_DICT will be removed.

After this change, I'll tag a v0.10.0 transition version with deprecation warnings, and then I'll release a v1.0.0, in compliance with Semantic Versioning .

@felipenoris felipenoris self-assigned this Apr 17, 2020
@felipenoris felipenoris added this to the v1.0 milestone Apr 17, 2020
@felipenoris felipenoris changed the title Breaking changes for HolidayCalendarCache [Breaking] changes for HolidayCalendarCache Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant