Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ReactiveArgumentResolver #1263

Open
esfomeado opened this issue Oct 7, 2022 · 4 comments
Open

feature: ReactiveArgumentResolver #1263

esfomeado opened this issue Oct 7, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@esfomeado
Copy link
Contributor

Describe the Feature Request

As of now is only possible to resolve non reactive arguments using the ArgumentResolver interface.

Will be cool to be able to resolve as well some reactive arguments for instance to get a claim from the token using the ReactiveSecurityContextHolder.getContext().

Describe Preferred Solution

Have a ReactiveArgumentResolver interface or some other approach to would enable to return Mono on an ArgumentResolver.

Describe Alternatives

@esfomeado esfomeado added the enhancement New feature or request label Oct 7, 2022
@srinivasankavitha
Copy link
Contributor

Thanks for opening the issue. We have some basic reactive support but haven't yet fully explored all the aspects required to make it first-class in the framework. This is primarily due to the fact that we haven't widely adopted it internally. It's great to get an idea of all the existing gaps so we can prioritize for future.

@github-actions github-actions bot added the stale label Oct 8, 2023
@pavandv
Copy link

pavandv commented Mar 4, 2024

One requirement is to use the @authenticationprincipal in the @dgsDataFetcher so we can access the Principal object.

I think this is the biggest requirement for anyone who wants to use Reactive Dgs.

@github-actions github-actions bot removed the stale label Mar 5, 2024
@pavandv
Copy link

pavandv commented Mar 8, 2024

Hi @srinivasankavitha, do you have any update on this?

@srinivasankavitha
Copy link
Contributor

We won't be prioritizing this feature for now, since we don't use reactive stack internally. However, we are working on a release that integrates with spring-graphql in the coming weeks. With that, perhaps I am expecting you should be able leverage the support that is available for reactive stack from spring-graphql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants