Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect assets file change telemetry #6207

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Dec 21, 2024

Bug

Related: NuGet/Home#6987

Description

I have a theory that a very, very large majority of force restore (or effective VS rebuild) events do not change the assets file.
The idea is that we don't need to do force restore during a rebuild, thus saving CPU time.

In this change, I'll add new properties to the restore event, to help me validate that theory.

  • ForceRestore (I know the name is opposite from the property, but that ship has sailed, in vs/nuget/restoreinformation we already have this property so this just makes the values consistent).
  • UpdatedAssetsFile - indicates whether the assets file needs to be updated as a consequence of this restore
  • UpdatedMSBuildFiles - indicates whether the msbuild files need to be updated as a consequence of this restore
  • IsPackageInstallationTrigger - tells that a restore was triggered due to a PM UI or PMC package installation. In this case, we should ignore any no-op specifics.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant