Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerPart's "Show on admin menu" functionality doesn't work without Orchard.Lists enabled #8808

Open
BenedekFarkas opened this issue Nov 18, 2024 · 0 comments · Fixed by #8809
Open

ContainerPart's "Show on admin menu" functionality doesn't work without Orchard.Lists enabled #8808

BenedekFarkas opened this issue Nov 18, 2024 · 0 comments · Fixed by #8809
Assignees
@BenedekFarkas
Milestone
Orchard 1.10.4

Comments

@BenedekFarkas
Copy link
Member

Not to be confused with AdminMenuPart, because ContainerPart implement its own logic for it. At least partially, because the items won't show up unless Orchard.Lists is also enabled. This can be fixed easily by moving most of the logic from Orchard.Lists.AdminMenu to Core.Containers.AdminMenu.
@BenedekFarkas BenedekFarkas self-assigned this Nov 18, 2024
@BenedekFarkas BenedekFarkas added this to the Orchard 1.10.4 milestone Nov 18, 2024
@BenedekFarkas BenedekFarkas mentioned this issue Nov 20, 2024
Merged
@BenedekFarkas BenedekFarkas linked a pull request Nov 20, 2024 that will close this issue
#8808: Fixing Container admin navigation #8809
Merged
BenedekFarkas added a commit that referenced this issue Dec 10, 2024
@BenedekFarkas
#8808: Fixing Container admin navigation (#8809)
1c40b8b 
* Fixing that Core.Containers "Show on admin menu" functionality shouldn't depend on the Orchard.Lists feature

* Moving menu.list.png admin menu icon from Orchard.Lists to Core.Containers as menu.container.png

to fix that Containers should have a default admin menu icon

* Fixing conflict between lists and container admin navicon by applying the unused menu.list-definition.png to lists

* Code styling and removing duplicate code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenedekFarkas BenedekFarkas

Labels
None yet
Projects
None yet
Milestone
Orchard 1.10.4
Development

Successfully merging a pull request may close this issue.

#8808: Fixing Container admin navigation OrchardCMS/Orchard
1 participant
@BenedekFarkas