Fix to import Vimeo videos #8804
Conversation
… api url to the call to properly download video metadata.
|
I think this is really wrong. If Vimeo doesn't support OEmbed then it's better to have another feature dedicated to vimeo, or just drop vimeo support altogether. |
…t changes to Youtube page markup
…there the correct api url.
Vimeo still supports embed (and the xml format is still the same) but it doesn't include the link to the video metadata xml in its markup anymore, so it cannot be automatically imported by directly reading the video page content. While investigating further, we also noticed Youtube stopped working too. This is caused by the fact it blocks video output when trying to watch a video from a server (a bot protection). This is what happened when I tried to debug the Youtube issue directly from the server: I was trying to find a way to get the meta link in the page, but that's what the page shows: For this reason, we worked on a patch on the code, similar to what has already been done to get Vimeo's oembed xml data: to properly get the provider, we check for the url we're redirected to and, with that information, call the right api. |
| // <link rel="alternate" href="http://vimeo.com/api/oembed.xml?url=http%3A%2F%2Fvimeo.com%2F23608259" type="text/xml+oembed"> | ||
|
|
There was a problem hiding this comment.
| // <link rel="alternate" href="http://vimeo.com/api/oembed.xml?url=http%3A%2F%2Fvimeo.com%2F23608259" type="text/xml+oembed"> |
| var content = webClient.DownloadString(Server.HtmlDecode(href)); | ||
| viewModel.Content = XDocument.Parse(content); | ||
| } catch { | ||
| // bubble exception |
There was a problem hiding this comment.
| // bubble exception | |
| throw; |
| source = webClient.DownloadString(url); | ||
|
|
||
| viewModel.Content = XDocument.Parse(source); | ||
| } else if (youtube) { |
There was a problem hiding this comment.
| } else if (youtube) { | |
| } | |
| else if (youtube) { |
| source = webClient.DownloadString(url); | ||
|
|
||
| viewModel.Content = XDocument.Parse(source); | ||
| } else { |
There was a problem hiding this comment.
| } else { | |
| } | |
| else { |
| try { | ||
| var content = webClient.DownloadString(Server.HtmlDecode(href)); | ||
| viewModel.Content = XDocument.Parse(content); | ||
| } catch { |
There was a problem hiding this comment.
| } catch { | |
| } | |
| catch { |
| @@ -137,8 +165,7 @@ public ActionResult IndexPOST(string folderPath, string url, string type, string | |||
| root.El("description", description); | |||
| } | |||
| Response.AddHeader("X-XSS-Protection", "0"); // Prevents Chrome from freaking out over embedded preview | |||
| } | |||
| catch { | |||
| } catch { | |||
There was a problem hiding this comment.
| } catch { | |
| } | |
| catch { |
| @@ -167,8 +194,7 @@ public ActionResult Import(string folderPath, string url, string document) { | |||
|
|
|||
| if (oembed.Element("title") != null) { | |||
| part.Title = oembed.Element("title").Value; | |||
| } | |||
| else { | |||
| } else { | |||
There was a problem hiding this comment.
| } else { | |
| } | |
| else { |
| @@ -213,8 +239,7 @@ public ActionResult Replace(int replaceId, string url, string document) { | |||
|
|
|||
| if (oembed.Element("title") != null) { | |||
| replaceMedia.Title = oembed.Element("title").Value; | |||
| } | |||
| else { | |||
| } else { | |||
There was a problem hiding this comment.
| } else { | |
| } | |
| else { |
| HttpWebRequest myHttpWebRequest = (HttpWebRequest)WebRequest.Create(myUri); | ||
| // Send the request and wait for response. | ||
| HttpWebResponse myHttpWebResponse = (HttpWebResponse)myHttpWebRequest.GetResponse(); | ||
|
|
||
| if (!myUri.Equals(myHttpWebResponse.ResponseUri)) { | ||
| myUri = myHttpWebResponse.ResponseUri; | ||
| } | ||
|
|
||
| // Release resources of response object. | ||
| myHttpWebResponse.Close(); |
There was a problem hiding this comment.
| HttpWebRequest myHttpWebRequest = (HttpWebRequest)WebRequest.Create(myUri); | |
| // Send the request and wait for response. | |
| HttpWebResponse myHttpWebResponse = (HttpWebResponse)myHttpWebRequest.GetResponse(); | |
| if (!myUri.Equals(myHttpWebResponse.ResponseUri)) { | |
| myUri = myHttpWebResponse.ResponseUri; | |
| } | |
| // Release resources of response object. | |
| myHttpWebResponse.Close(); | |
| var myHttpWebRequest = WebRequest.Create(myUri) as HttpWebRequest; | |
| // Send the request and wait for response. | |
| using (var myHttpWebResponse = myHttpWebRequest.GetResponse() as HttpWebResponse) { | |
| if (!myUri.Equals(myHttpWebResponse.ResponseUri)) { | |
| myUri = myHttpWebResponse.ResponseUri; | |
| } | |
| } |
@sebastienros what do you think? BTW I tested the YouTube import (but couldn't test Vimeo), works fine. |
|
Let's keep oembed as is, it's oembed. Add some other option called youtube, another one for vimeo and they are dedicated. Or a single one called "video" which would support whatever we want. Copy as much as you want from the current oembed. |
In reference to #8803 , added a fix to avoid the scraping of the "vimeo.com/xxxx" page (which replies with a 429 http error) by forcing the direct api call if Vimeo domain is recognized.