Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent redirects during external auto-login #17220

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

MikeAlhayek
Copy link
Member

Fix #17219

@MikeAlhayek MikeAlhayek requested a review from Piedone December 11, 2024 23:18
@MikeAlhayek MikeAlhayek merged commit 87a21fe into main Dec 12, 2024
8 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/auto-redirect-exteranl-auth branch December 12, 2024 17:01
@MikeAlhayek
Copy link
Member Author

/backport to release/2.1

Copy link
Contributor

Started backporting to release/2.1: https://github.com/OrchardCMS/OrchardCore/actions/runs/12301183973

Copy link
Contributor

@MikeAlhayek backporting to release/2.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix intermittent redirects during external auto-login Fix #17219
Using index info to reconstruct a base tree...
M	src/OrchardCore.Modules/OrchardCore.Users/Services/ExternalLoginFormEvents.cs
Falling back to patching base and 3-way merge...
Auto-merging src/OrchardCore.Modules/OrchardCore.Users/Services/ExternalLoginFormEvents.cs
CONFLICT (content): Merge conflict in src/OrchardCore.Modules/OrchardCore.Users/Services/ExternalLoginFormEvents.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix intermittent redirects during external auto-login Fix #17219
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchard Core intermittently displays login options when only one external provider is configured
1 participant