Add DeploymentStepDriverBase & DeploymentStepFieldsDriverBase #16874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hishamco
commented
Oct 12, 2024
•
hishamco
commented
- Reduce the code boilerplate for both the deployment step driver & deployment step fields driver
- No more magic strings for deployment steps shapes
hishamco
force-pushed
the
hishamco/deployment-step-driver
branch
from
d0600f9 to
146778c
Compare
hishamco
changed the title
|
@hishamco I don't think this is a good idea and may add more things to learn for no added value. |
|
why there's no value, most of the time lost in a typo in a shape name during the deployment, please keep this open for now and I might open another PR to avoid magic strings at least. Then we can have a choice to keep it or break it |
|
Because it hide too much details and it's hard to understand what is happening with the code. The logic in drivers should be visible so have full control and full visibility on what the code does. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.