Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for customizable serverless nodejs runtime version for Vercel adapter #1329

Open
thescientist13 opened this issue Nov 28, 2024 · 0 comments · May be fixed by #1330
Open

allow for customizable serverless nodejs runtime version for Vercel adapter #1329

thescientist13 opened this issue Nov 28, 2024 · 0 comments · May be fixed by #1330
Assignees
@thescientist13
Labels
Adapter alpha.3 documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins v0.31.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

Feature

Summary

In the context of #1202 and that Greenwood works as expected with all current versions of NodeJS

  • 18.x
  • 20.x
  • 22.x

We should allow this configuration for the Vercel adapter, since this is a configuration item for Vercel's build output API.

Details

I think coming out of #1326 , looks like we might need to also bump the minimum version to 20.x. We should also document this in plugin's README.
@thescientist13 thescientist13 added documentation Greenwood specific docs feature New feature or request Adapter labels Nov 28, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 28, 2024
@thescientist13 thescientist13 self-assigned this Nov 28, 2024
@thescientist13 thescientist13 changed the title allow for customizable serverless runtime for Vercel Adapter allow for customizable serverless runtime option for Vercel Adapter Nov 28, 2024
@thescientist13 thescientist13 linked a pull request Nov 28, 2024 that will close this issue
Open
1 task
@thescientist13 thescientist13 added the Plugins Greenwood Plugins label Nov 28, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Nov 28, 2024
@thescientist13 thescientist13 changed the title allow for customizable serverless runtime option for Vercel Adapter allow for customizable serverless runtime version for Vercel Adapter Dec 13, 2024
@thescientist13 thescientist13 changed the title allow for customizable serverless runtime version for Vercel Adapter allow for customizable serverless nodejs runtime version for Vercel Adapter Dec 13, 2024
@thescientist13 thescientist13 changed the title allow for customizable serverless nodejs runtime version for Vercel Adapter allow for customizable serverless nodejs runtime version for Vercel adapter Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
Adapter alpha.3 documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins v0.31.0
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: 👀 In review
Milestone
1.0
1 participant
@thescientist13