Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Make paymentDetails field within PrivatePaymentDetail object required instead of optional #308

Open
kirahsapong opened this issue Mar 31, 2024 · 0 comments

Comments

@kirahsapong
Copy link
Contributor

kirahsapong commented Mar 31, 2024

paymentDetails is marked as optional within the PrivatePaymentDetail object, which is also optional in privateData.

Proposal: paymentDetails should be required. ie. If passing the optional PrivatePaymentDetail, it must contain paymentDetails.

https://github.com/TBD54566975/tbdex/tree/main/specs/protocol#privatepaymentdetails

| field            | data type | required | description                                                                                                                                                                                                                                |
| ---------------- | --------- | -------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| `paymentDetails` | object    | N        | An object containing the properties defined in an Offering's `requiredPaymentDetails` json schema. If `data.payin/payout.paymentDetailsHash` is omitted, then `privateData.payin/payout.paymentDetails` respectively must also be omitted. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant