Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Introduce Payout unit and payin unit enums #342

Open
jiyoonie9 opened this issue Jul 4, 2024 · 0 comments
Open

Introduce Payout unit and payin unit enums #342

jiyoonie9 opened this issue Jul 4, 2024 · 0 comments

Comments

@jiyoonie9
Copy link
Contributor

To describe payoutUnitsPerPayinUnit, the spec says something to the effect of "smallest unit of measurement" however we have used dollars and btc to describe say USD/BTC. Using smallest unit of measurement would mean we'd use cents and sats. But that isn't always the "typical" measurements used in a USD/BTC rate.

We should probably remove that wording in the spec and either

  1. introduce two new fields (payin/out currency unit)
  2. Modify payin/out currency to include unit of measurement used to describe payoutUnitsPerPayinUnit (ie USD_Dollars)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant