Skip to content

Latest commit

 

History

History
79 lines (47 loc) · 2.63 KB

CHANGELOG.MD

File metadata and controls

79 lines (47 loc) · 2.63 KB
Raw

CHANGELOG.md

Feedback sep-he (Dec 16, 2024)

GitHub Issue associated with addressing feedback: #62

Pull Request: #63

Documentation Improvements

•	Added a “Support” section and included Docker in the “Dependencies” section of README.md.

Code Readability

•	Used a more descriptive name for the figure.
•	Added titles to the charts to enhance clarity for the audience.
•	Used a more descriptive name for the function.
•	Used a parameter instead of hardcoding the train_df path.

Introduction and Importance

•	Provided a more detailed explanation of why right-handed players have an advantage and how this insight could significantly benefit NHL teams in competitions.

Data Presentation

•	Included specific numbers about left- vs. right-handed players in the “Looking at the Data” section.

Feedback Rashidikn1 (Dec 15, 2024)

GitHub Issue associated with addressing feedback: #55

Pull Request: #57

Code quality

  • Changed name of preprocess.py to preprocess_and_validate.py to be more descriptive.

General checks

  • Added Creative Commons License to LICENSE.md

Feedback mdahewlett (Dec 15, 2024)

GitHub Issue associated with addressing feedback: #56

Pull request: #58

Functionality documentation

  • Added documentation to eda.py and shooting_hand_classifier.py.

Methods

  • Added assumptions and limitations section to methods.

Results

  • Updated misleading statement in the results section of our report.

References

  • Updated Altair reference to add DOI.

Feedback hovhannisyannell (Dec 12, 2024)

Pull request: #44

Documentation

  • Information about specific features (height, weight) used within model added.
  • Hyperparameter tuning was not attempted (as explicitly stated in report) so no changes were made
  • Reasons for using logisitic regression added

Automated tests

  • Automated tests added to report to validate data

Report (writing)

  • Introduction section changed to focus more on key points (importance of being able to predict shooting hand)
  • Emphasis of value of this analysis to NHL teams also added to introduction

Conclusion

  • Broader implications of results in scouting already addressed in section 'What impact could such findings have?'
  • Taking into account additional variables is already addressed in our final section