You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"fetch and decode trusted scoring signals" takes a policyContainer object as an argument, but is not passed one by "score and rank a bid", which itself does not have a policyContainer or "global’s relevant settings object" from which to derive one.
I think we need to make "score and rank a bid" take a policyContainer, and pass it along, and update all (3?) call sites to pass one in. While we're thinking about it, we could instead pass in the IP address space, largely for clarity - I had a lot of trouble following the scoring calls down to discover that's the only field we use, because of how the scoring batching logic is structured (bidder batching was much easier to follow).
Filing this as a bug instead of fixing it because the KVv2 PR may change the structure of the document a lot, and resolving conflicts often leads to more spec bugs of the same nature as this one.
The text was updated successfully, but these errors were encountered:
"fetch and decode trusted scoring signals" takes a policyContainer object as an argument, but is not passed one by "score and rank a bid", which itself does not have a policyContainer or "global’s relevant settings object" from which to derive one.
I think we need to make "score and rank a bid" take a policyContainer, and pass it along, and update all (3?) call sites to pass one in. While we're thinking about it, we could instead pass in the IP address space, largely for clarity - I had a lot of trouble following the scoring calls down to discover that's the only field we use, because of how the scoring batching logic is structured (bidder batching was much easier to follow).
Filing this as a bug instead of fixing it because the KVv2 PR may change the structure of the document a lot, and resolving conflicts often leads to more spec bugs of the same nature as this one.
The text was updated successfully, but these errors were encountered: