Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: "fetch and decode trusted scoring signals" takes a policyContainer, but is not passed one. #1372

Open
MattMenke2 opened this issue Dec 19, 2024 · 0 comments

Comments

@MattMenke2
Copy link
Contributor

"fetch and decode trusted scoring signals" takes a policyContainer object as an argument, but is not passed one by "score and rank a bid", which itself does not have a policyContainer or "global’s relevant settings object" from which to derive one.

I think we need to make "score and rank a bid" take a policyContainer, and pass it along, and update all (3?) call sites to pass one in. While we're thinking about it, we could instead pass in the IP address space, largely for clarity - I had a lot of trouble following the scoring calls down to discover that's the only field we use, because of how the scoring batching logic is structured (bidder batching was much easier to follow).

Filing this as a bug instead of fixing it because the KVv2 PR may change the structure of the document a lot, and resolving conflicts often leads to more spec bugs of the same nature as this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant