Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #146 - Specify GREASE algorithms (aka arbitrary brand and version number) #178

Merged
merged 8 commits into from
Jan 8, 2021

Conversation

miketaylr
Copy link
Collaborator

@miketaylr miketaylr commented Jan 5, 2021

PTAL @amtunlimited

(Right now I'm running a crawler to ensure _ ( ) ; ? = - : . / are safe to use, but so far it's looking good).

This also should address #161.


Preview | Diff

@miketaylr miketaylr requested a review from amtunlimited January 5, 2021 23:10
@miketaylr miketaylr linked an issue Jan 5, 2021 that may be closed by this pull request
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@miketaylr miketaylr requested a review from amtunlimited January 7, 2021 19:00
Copy link
Contributor

@amtunlimited amtunlimited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miketaylr
Copy link
Collaborator Author

Thanks for the review!

@miketaylr miketaylr merged commit e3b93ea into WICG:master Jan 8, 2021
@miketaylr miketaylr deleted the issues/146/1 branch January 8, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GREASE algorithm is underspecified Escaped string and backslash not web compatible SF string quoting
2 participants