Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new input to skip cache updates #751

Open
ozancaglayan opened this issue Oct 23, 2023 · 6 comments
Open

Add a new input to skip cache updates #751

ozancaglayan opened this issue Oct 23, 2023 · 6 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@ozancaglayan
Copy link

ozancaglayan commented Oct 23, 2023

Description:

When this action is used with caching enabled, PRs and non-main branches creates new cache artifacts which may be overwhelming. This can be mitigated if something like skip-cache-update: bool option is added and users define it as false if the action runs in a branch that is not main. This would skip the post stage of the action to effectively cancel the cache pushing.

@ozancaglayan ozancaglayan added feature request New feature or request to improve the current logic needs triage labels Oct 23, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @ozancaglayan. Thank you for your feature request. We'll take a look on it.

@akx
Copy link
Contributor

akx commented Nov 10, 2023

Ah, turns out I had the same idea! #762

@aparnajyothi-y
Copy link
Contributor

Hello Everyone, Thank you for your feature request. The idea of adding a skip-cache-update option to control cache updates is valuable; however, it could increase complexity for users, and there’s a risk of missing out on potential caching benefits. Additionally, it would require maintenance and documentation updates.
We appreciate your suggestion and will continue to evaluate other ways to optimize caching.

@aparnajyothi-y aparnajyothi-y self-assigned this Nov 27, 2024
@aparnajyothi-y
Copy link
Contributor

Hello Everyone, Please let us know in case of clarifications needed on the above.

@akx
Copy link
Contributor

akx commented Dec 9, 2024

@aparnajyothi-y Please see my rationale for adding this feature in #762.

@aparnajyothi-y
Copy link
Contributor

Hello @akx, Thank you for your contribution to #762 and for sharing your thoughts on this feature request.
While we appreciate the idea, we’re concerned that it may introduce additional complexity and could potentially limit caching benefits. Furthermore, it would require ongoing maintenance and updates to documentation. Given these factors, we’ve decided to not move forward with this change at this time.

We truly appreciate your understanding and patience, and we encourage you to continue sharing any further thoughts or suggestions you may have.

kdeldycke added a commit to kdeldycke/workflows that referenced this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

4 participants