Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser console prints stop working when socket connects #26

Open
alesya-h opened this issue Sep 16, 2015 · 2 comments
Open

Browser console prints stop working when socket connects #26

alesya-h opened this issue Sep 16, 2015 · 2 comments

Comments

@alesya-h
Copy link

There should be a way to set weasel's :print value. Currently it is not configured, so defaults to :repl. This leads to vanishing of browser logging (enabled via (enable-console-print!)) when boot-cljs-repl's script is loaded.

@alesya-h alesya-h changed the title Browser prints stop working when socket connects Browser console prints stop working when socket connects Sep 16, 2015
@danielsz
Copy link

Bumped into this too.

@candland
Copy link

+1

AdamFrey added a commit to AdamFrey/boot-cljs-repl that referenced this issue Jun 28, 2016
Weasel by default overwrites the *print-fn* global variable to redirect
all printing to the REPL after the REPL connection has been opened. In
practice this means that if you are using boot-cljs-repl and are also
printing to the console via `(enable-console-print)`, your console printing will
work for an abritrary period of time until it doesn't anymore.

This patch configures Weasel to set the *print-fn* to print to the REPL
and the console. IMO, this is the best default to ensure that users
aren't confused when half print statements stop working. It's not at all
obvious that what the cause is and the amount of people that will be run
into this problem is large.

I'm also open to exposing this as an option for the task, if you think
that's a good idea.

Addresses this issue: adzerk-oss#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants