-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with page #/page size vs index/offset #58
Comments
would you share a repro? |
I could give you the API source/doc but the specific endpoint that'll utilize endless scroll hasn't been finished yet. I can't share my project due to NDA. |
My take on this was:
Be aware that ui-scroll's index is one based while the arrays are zero based. In my case it was just the case to decrement the index before anything as my pages are also zero based. #44 |
While I semi-understand what you did, it seems like a lot of fetching and fandangling for something that could be fixed easily with an option in ui-scroll for buffer clip size. Some sort of option that would allow ui-scrolls use of index/offset to keep index a multiple of count so that APIs using page # and page size can use this as well with minimal effort. And similarily, a toggle to not allow negative index would be nice. Flexibility is the key. |
I'm wondering if anyone has been able to make this module work using page #/page size API calls? The API i'm plugging into requires these instead of index & offset. Calls when scrolling down are obvious & easy, but because of the way the buffer clears itself, I haven't found a way to make it work when scrolling up. Could the buffer functionality be changed to remove whole chunks instead of half?
The text was updated successfully, but these errors were encountered: