Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend EXTRA_RELATED_QUERY_FILTERS to "MODIFIED BY" filter. #31604

Open
pablitosky opened this issue Dec 23, 2024 · 0 comments
Open

Extend EXTRA_RELATED_QUERY_FILTERS to "MODIFIED BY" filter. #31604

pablitosky opened this issue Dec 23, 2024 · 0 comments
Labels
change:backend Requires changing the backend sip Superset Improvement Proposal

Comments

@pablitosky
Copy link

pablitosky commented Dec 23, 2024

[SIP] Proposal for ...EXTRA_RELATED_QUERY_FILTERS on 4.0.2

Motivation

EXTRA_RELATED_QUERY_FILTERS are applied only to "OWNER" filter while exposing all users under "MODIFIED BY".

The code used for filtering:

def user_filter(query):
    from sqlalchemy.sql import false
    return query.filter(false())

EXTRA_RELATED_QUERY_FILTERS = {
    "user": user_filter,
}

Users correctly hidden in "OWNER":
image

Users exposed in "MODIFIED BY":
image

Proposed Change

Extend EXTRA_RELATED_QUERY_FILTERS functionality to "MODIFIED BY" FILTER in dashboards or charts view.

@pablitosky pablitosky added the sip Superset Improvement Proposal label Dec 23, 2024
@dosubot dosubot bot added the change:backend Requires changing the backend label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:backend Requires changing the backend sip Superset Improvement Proposal
Projects
None yet
Development

No branches or pull requests

1 participant