Cannot bootstrap atom for development with Node 18 #427

IneptusMechanicus · 2022-07-04T12:25:28Z

IneptusMechanicus
Jul 4, 2022

I'm trying to setup a dev environment for Atom. When running the script/bootstrap command. I'm attaching the full error log from running the command.

I've not done anything else to the code, I've simply cloned the repo and attempted to run the bootstrap command.

My system is a Lenovo Legion 5 laptop with a Ryzen 5 4800H and a GTX 1650, running Pop!_OS 22.04.

I don't know what else to say really, if I'm missing something or more system info dumps are necessary, I'll share ASAP.

Thank you!
bootstrap-error.log

Answered by aminya

Jul 4, 2022

Please follow the instructions in https://github.com/atom-community/atom/blob/master/docs/Building.md

The requirements are clearly stated. You need Node 12.18.3 version, npm 6, and a C++ compiler (e.g. Visual Studio 2017). You can also see the official preparation step of our CI image that is tested continuously:
https://github.com/atom-community/atom/blob/master/script/vsts/platforms/templates/preparation.yml

The reason your build has failed is that you are building for a newer Nodejs target. We can probably avoid this by adding target=12.18.3 to .npmrc. You can also define it by setting the environment variable npm_config_target=12.18.3

View full answer

mauricioszabo · 2022-07-04T15:07:50Z

mauricioszabo
Jul 4, 2022

I also can't reliably run the ./script/bootstrap. From what I know, it needs a very specific node and npm versions. What I did is try to change the process to run with yarn by adding some dependencies on devDependencies - that may allow you to develop Atom while we either fix the bootstrap scripts or change the way we bundle Atom. If you want to check, it's on this PR: #420

We'll probably migrate away to pnpm in the future, but in the meantime, feel free to try this alternative method - it's actually what I'm using to bump some packages' versions and Electron

0 replies

aminya · 2022-07-04T23:10:26Z

aminya
Jul 4, 2022
Maintainer

Please follow the instructions in https://github.com/atom-community/atom/blob/master/docs/Building.md

The requirements are clearly stated. You need Node 12.18.3 version, npm 6, and a C++ compiler (e.g. Visual Studio 2017). You can also see the official preparation step of our CI image that is tested continuously:
https://github.com/atom-community/atom/blob/master/script/vsts/platforms/templates/preparation.yml

The reason your build has failed is that you are building for a newer Nodejs target. We can probably avoid this by adding target=12.18.3 to .npmrc. You can also define it by setting the environment variable npm_config_target=12.18.3

10 replies

DeeDeeG Jul 7, 2022

@IneptusMechanicus if you can describe what particularly wasn't being done right, and what fixed it, even if it's obscure nvm stuff, I personally am interested, so we can better advise others who are running into the same problem. I have used nvm before, so I know a bit about it. Just curious if there is a specific fix we can tell people, or if you have any clues as to what went wrong. Thanks.

mauricioszabo Jul 8, 2022

I have to say, I suffer from the same problem. Even after following all instructions (strictly installed Node 12.18.3, had to set python's env vars manually) I could boostrap but the editor itself fails with this error:

So.... I'm unsure how to proceed too...

IneptusMechanicus Jul 8, 2022
Author

@DeeDeeG I was simply forgetting to switch my Node version, since I need the latest node version for ReactJS development. It defaults to 18.4.0 and I keep forgetting to switch to Node 12. The node version I'm using is 12.22.2 though, so I don't know how different the results would be.

IneptusMechanicus Jul 8, 2022
Author

I did however fail to mention, that I get this output on the "Installing apm" step of the script, even though the whole thing technicalli passes

In file included from ../../nan/nan.h:60,
                 from ../src/onig-scanner.h:4,
                 from ../src/onig-scanner.cc:1:
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:608:7: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>)’ to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
  608 |       (node::addon_register_func) (regfunc),                          \
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:642:3: note: in expansion of macro ‘NODE_MODULE_X’
  642 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../src/onig-scanner.cc:23:1: note: in expansion of macro ‘NODE_MODULE’
   23 | NODE_MODULE(onig_scanner, InitModule)
      | ^~~~~~~~~~~
../deps/libgit2/deps/zlib/infback.c: In function ‘inflateBack’:
../deps/libgit2/deps/zlib/infback.c:479:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  479 |             state->mode = LEN;
      |             ~~~~~~~~~~~~^~~~~
../deps/libgit2/deps/zlib/infback.c:481:9: note: here
  481 |         case LEN:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c: In function ‘inflate’:
../deps/libgit2/deps/zlib/inflate.c:841:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  841 |             state->mode = DICT;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:842:9: note: here
  842 |         case DICT:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:848:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  848 |             state->mode = TYPE;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:849:9: note: here
  849 |         case TYPE:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:850:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
  850 |             if (flush == Z_BLOCK || flush == Z_TREES) goto inf_leave;
      |                ^
../deps/libgit2/deps/zlib/inflate.c:851:9: note: here
  851 |         case TYPEDO:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:900:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
  900 |             if (flush == Z_TREES) goto inf_leave;
      |                ^
../deps/libgit2/deps/zlib/inflate.c:901:9: note: here
  901 |         case COPY_:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:902:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  902 |             state->mode = COPY;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:903:9: note: here
  903 |         case COPY:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1041:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1041 |             if (flush == Z_TREES) goto inf_leave;
      |                ^
../deps/libgit2/deps/zlib/inflate.c:1042:9: note: here
 1042 |         case LEN_:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1043:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1043 |             state->mode = LEN;
      |             ~~~~~~~~~~~~^~~~~
../deps/libgit2/deps/zlib/inflate.c:1044:9: note: here
 1044 |         case LEN:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1092:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1092 |             state->mode = LENEXT;
      |             ~~~~~~~~~~~~^~~~~~~~
../deps/libgit2/deps/zlib/inflate.c:1093:9: note: here
 1093 |         case LENEXT:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1102:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1102 |             state->mode = DIST;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:1103:9: note: here
 1103 |         case DIST:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1129:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1129 |             state->mode = DISTEXT;
      |             ~~~~~~~~~~~~^~~~~~~~~
../deps/libgit2/deps/zlib/inflate.c:1130:9: note: here
 1130 |         case DISTEXT:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1145:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1145 |             state->mode = MATCH;
      |             ~~~~~~~~~~~~^~~~~~~
../deps/libgit2/deps/zlib/inflate.c:1146:9: note: here
 1146 |         case MATCH:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1233:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1233 |             state->mode = DONE;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:1234:9: note: here
 1234 |         case DONE:
      |         ^~~~
../deps/libgit2/deps/http-parser/http_parser.c: In function ‘http_parser_parse_url’:
../deps/libgit2/deps/http-parser/http_parser.c:2094:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
 2094 |         found_at = 1;
      |         ~~~~~~~~~^~~
../deps/libgit2/deps/http-parser/http_parser.c:2097:7: note: here
 2097 |       case s_req_server:
      |       ^~~~
In file included from ../../nan/nan.h:60,
                 from ../src/repository.h:29,
                 from ../src/repository.cc:22:
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:608:7: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>)’ to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
  608 |       (node::addon_register_func) (regfunc),                          \
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:642:3: note: in expansion of macro ‘NODE_MODULE_X’
  642 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../src/repository.cc:71:1: note: in expansion of macro ‘NODE_MODULE’
   71 | NODE_MODULE(git, Repository::Init)
      | ^~~~~~~~~~~
../src/repository.cc: In member function ‘virtual void Repository::GetHeadAsync(Nan::NAN_METHOD_ARGS_TYPE)::HeadAsyncWorker::HandleOKCallback()’:
../src/repository.cc:242:21: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  242 |       callback->Call(2, argv);
      |       ~~~~~~~~~~~~~~^~~~~~~~~
In file included from ../src/repository.h:29,
                 from ../src/repository.cc:22:
../../nan/nan.h:1746:3: note: declared here
 1746 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/repository.cc: In member function ‘virtual void Repository::GetStatusAsync(Nan::NAN_METHOD_ARGS_TYPE)::StatusAsyncWorker::HandleOKCallback()’:
../src/repository.cc:412:21: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  412 |       callback->Call(2, argv);
      |       ~~~~~~~~~~~~~~^~~~~~~~~
In file included from ../src/repository.h:29,
                 from ../src/repository.cc:22:
../../nan/nan.h:1746:3: note: declared here
 1746 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/repository.cc: In member function ‘virtual void Repository::CompareCommitsAsync(Nan::NAN_METHOD_ARGS_TYPE)::CompareCommitsAsyncWorker::HandleOKCallback()’:
../src/repository.cc:749:21: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  749 |       callback->Call(2, argv);
      |       ~~~~~~~~~~~~~~^~~~~~~~~
In file included from ../src/repository.h:29,
                 from ../src/repository.cc:22:
../../nan/nan.h:1746:3: note: declared here
 1746 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
In file included from ../../nan/nan.h:60,
                 from ../src/onig-scanner.h:4,
                 from ../src/onig-scanner.cc:1:
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:608:7: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>)’ to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
  608 |       (node::addon_register_func) (regfunc),                          \
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:642:3: note: in expansion of macro ‘NODE_MODULE_X’
  642 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../src/onig-scanner.cc:23:1: note: in expansion of macro ‘NODE_MODULE’
   23 | NODE_MODULE(onig_scanner, InitModule)
      | ^~~~~~~~~~~
../deps/libgit2/deps/zlib/infback.c: In function ‘inflateBack’:
../deps/libgit2/deps/zlib/infback.c:479:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  479 |             state->mode = LEN;
      |             ~~~~~~~~~~~~^~~~~
../deps/libgit2/deps/zlib/infback.c:481:9: note: here
  481 |         case LEN:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c: In function ‘inflate’:
../deps/libgit2/deps/zlib/inflate.c:841:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  841 |             state->mode = DICT;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:842:9: note: here
  842 |         case DICT:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:848:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  848 |             state->mode = TYPE;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:849:9: note: here
  849 |         case TYPE:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:850:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
  850 |             if (flush == Z_BLOCK || flush == Z_TREES) goto inf_leave;
      |                ^
../deps/libgit2/deps/zlib/inflate.c:851:9: note: here
  851 |         case TYPEDO:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:900:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
  900 |             if (flush == Z_TREES) goto inf_leave;
      |                ^
../deps/libgit2/deps/zlib/inflate.c:901:9: note: here
  901 |         case COPY_:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:902:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  902 |             state->mode = COPY;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:903:9: note: here
  903 |         case COPY:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1041:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1041 |             if (flush == Z_TREES) goto inf_leave;
      |                ^
../deps/libgit2/deps/zlib/inflate.c:1042:9: note: here
 1042 |         case LEN_:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1043:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1043 |             state->mode = LEN;
      |             ~~~~~~~~~~~~^~~~~
../deps/libgit2/deps/zlib/inflate.c:1044:9: note: here
 1044 |         case LEN:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1092:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1092 |             state->mode = LENEXT;
      |             ~~~~~~~~~~~~^~~~~~~~
../deps/libgit2/deps/zlib/inflate.c:1093:9: note: here
 1093 |         case LENEXT:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1102:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1102 |             state->mode = DIST;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:1103:9: note: here
 1103 |         case DIST:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1129:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1129 |             state->mode = DISTEXT;
      |             ~~~~~~~~~~~~^~~~~~~~~
../deps/libgit2/deps/zlib/inflate.c:1130:9: note: here
 1130 |         case DISTEXT:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1145:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1145 |             state->mode = MATCH;
      |             ~~~~~~~~~~~~^~~~~~~
../deps/libgit2/deps/zlib/inflate.c:1146:9: note: here
 1146 |         case MATCH:
      |         ^~~~
../deps/libgit2/deps/zlib/inflate.c:1233:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1233 |             state->mode = DONE;
      |             ~~~~~~~~~~~~^~~~~~
../deps/libgit2/deps/zlib/inflate.c:1234:9: note: here
 1234 |         case DONE:
      |         ^~~~
../deps/libgit2/deps/http-parser/http_parser.c: In function ‘http_parser_parse_url’:
../deps/libgit2/deps/http-parser/http_parser.c:2094:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
 2094 |         found_at = 1;
      |         ~~~~~~~~~^~~
../deps/libgit2/deps/http-parser/http_parser.c:2097:7: note: here
 2097 |       case s_req_server:
      |       ^~~~
In file included from ../../nan/nan.h:60,
                 from ../src/repository.h:29,
                 from ../src/repository.cc:22:
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:608:7: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>)’ to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
  608 |       (node::addon_register_func) (regfunc),                          \
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/ivo/.cache/node-gyp/12.18.3/include/node/node.h:642:3: note: in expansion of macro ‘NODE_MODULE_X’
  642 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../src/repository.cc:71:1: note: in expansion of macro ‘NODE_MODULE’
   71 | NODE_MODULE(git, Repository::Init)
      | ^~~~~~~~~~~
../src/repository.cc: In member function ‘virtual void Repository::GetHeadAsync(Nan::NAN_METHOD_ARGS_TYPE)::HeadAsyncWorker::HandleOKCallback()’:
../src/repository.cc:242:21: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  242 |       callback->Call(2, argv);
      |       ~~~~~~~~~~~~~~^~~~~~~~~
In file included from ../src/repository.h:29,
                 from ../src/repository.cc:22:
../../nan/nan.h:1746:3: note: declared here
 1746 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/repository.cc: In member function ‘virtual void Repository::GetStatusAsync(Nan::NAN_METHOD_ARGS_TYPE)::StatusAsyncWorker::HandleOKCallback()’:
../src/repository.cc:412:21: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  412 |       callback->Call(2, argv);
      |       ~~~~~~~~~~~~~~^~~~~~~~~
In file included from ../src/repository.h:29,
                 from ../src/repository.cc:22:
../../nan/nan.h:1746:3: note: declared here
 1746 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/repository.cc: In member function ‘virtual void Repository::CompareCommitsAsync(Nan::NAN_METHOD_ARGS_TYPE)::CompareCommitsAsyncWorker::HandleOKCallback()’:
../src/repository.cc:749:21: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  749 |       callback->Call(2, argv);
      |       ~~~~~~~~~~~~~~^~~~~~~~~
In file included from ../src/repository.h:29,
                 from ../src/repository.cc:22:
../../nan/nan.h:1746:3: note: declared here
 1746 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~

It might be relevant, since when I set the atom dev resource variable and try to run the atom --dev command on the repo, nothing happens and then I have to unset the environment variable so that I can run atom --dev again at all, regardles of args.

With the variable set, there are processes running, though. I don't know what to make of them, but clearly something is wrong. Here's a dump of the ps aux command:

ivo        86889  0.0  0.0  19904  2052 pts/4    S<   09:58   0:00 /bin/bash /usr/bin/atom --dev atom
ivo        86893 13.6  0.5 4659228 168476 pts/4  SNl  09:58   0:00 /usr/share/atom/atom --executed-from=/home/ivo/Documents/Projects/Studio --pid=86876 --dev atom
ivo        86897  0.6  0.1 218448 47188 pts/4    SN   09:58   0:00 /usr/share/atom/atom --type=zygote --no-zygote-sandbox
ivo        86898  1.3  0.1 218448 47228 pts/4    SN   09:58   0:00 /usr/share/atom/atom --type=zygote
ivo        86900  0.0  0.0 218448  9624 pts/4    SN   09:58   0:00 /usr/share/atom/atom --type=zygote
ivo        86927  3.5  0.2 562792 87184 pts/4    SNl  09:58   0:00 /usr/share/atom/atom --type=gpu-process --field-trial-handle=1637859561640043939,13852457889297575078,131072 --enable-features=WebComponentsV0Enabled --disable-features=SpareRendererForSitePerProcess --gpu-preferences=MAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAAABgAAAAAAAQAAAAAAAAAAAAAAAAAAAACAAAAAAAAAA= --shared-files
ivo        86954  0.5  0.1 284116 50848 pts/4    SNl  09:58   0:00 /usr/share/atom/atom --type=utility --field-trial-handle=1637859561640043939,13852457889297575078,131072 --enable-features=WebComponentsV0Enabled --disable-features=SpareRendererForSitePerProcess --lang=en-US --service-sandbox-type=network --shared-files=v8_snapshot_data:100

DeeDeeG Jul 8, 2022

@IneptusMechanicus the compiler warnings are normal, and we tend to just ignore them. I forget if we ever had it set up to hide those or not. I think they leak through because they use console.warn() and we are filtering for anything above console.log()/console.info()?? Something like that.

It is also normal for Atom to have multiple processes. One main process, some renderer processes, one gpu process, and it will spawn more as more windows are opened if I recall correctly. Not sure why atom --dev isn't working if you've set ATOM_DEV_RESOURCE_PATH to the atom repo dir you cloned. But the atom that you run as atom --dev needs to use the same electron version as the repo you built, or it will fail to load native modules and silently fail. So if you're using stable Atom, that's still on Electron 9, and it will not work on this repo's master branch, which is on Electron 11.

To get more useful debug output, you can use the actual atom binary rather than running it indirectly through the shell script. /usr/share/atom/atom --dev.

There are known deprecation warnings regarding Electron: Loading non-context-aware native module in renderer: [module path here]. This is deprecated, see https://github.com/electron/electron/issues/18397.

DeeDeeG · 2022-07-05T17:39:55Z

DeeDeeG
Jul 5, 2022

I was unable to reproduce this problem in Virtualbox running the Pop!_OS 22.04 Live ISO.

For what it's worth, this looks to be the relevant part of your log. It is a compilation error for native C++ code in the fs-admin package:

Error log snippet (click to expand)

4941 verbose stack Error: command failed
4941 verbose stack     at ChildProcess.<anonymous> (/home/ivo/.nvm/versions/node/v18.4.0/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:63:27)
4941 verbose stack     at ChildProcess.emit (node:events:537:28)
4941 verbose stack     at maybeClose (node:internal/child_process:1091:16)
4941 verbose stack     at ChildProcess._handle.onexit (node:internal/child_process:302:5)
4942 verbose pkgid [email protected]
4943 verbose cwd /home/ivo/Documents/Projects/Studio/Molekule/code-repos/atom/script
4944 verbose Linux 5.17.15-76051715-generic
4945 verbose node v18.4.0
4946 verbose npm  v8.12.1
4947 error code 1
4948 error path /home/ivo/Documents/Projects/Studio/Molekule/code-repos/atom/script/node_modules/fs-admin
4949 error command failed
4950 error command sh -c prebuild-install || node-gyp rebuild
4951 error make: Entering directory '/home/ivo/Documents/Projects/Studio/Molekule/code-repos/atom/script/node_modules/fs-admin/build'
4951 error   CXX(target) Release/obj.target/fs_admin/src/main.o
4951 error   CXX(target) Release/obj.target/fs_admin/src/fs-admin-linux.o
4951 error make: Leaving directory '/home/ivo/Documents/Projects/Studio/Molekule/code-repos/atom/script/node_modules/fs-admin/build'
4952 error In file included from ../src/main.cc:1:
4952 error ../../nan/nan.h: In function ‘void Nan::AsyncQueueWorker(Nan::AsyncWorker*)’:
4952 error ../../nan/nan.h:2298:7: warning: cast between incompatible function types from ‘void (*)(uv_work_t*)’ {aka ‘void (*)(uv_work_s*)’} to ‘uv_after_work_cb’ {aka ‘void (*)(uv_work_s*, int)’} [-Wcast-function-type]
4952 error  2298 |     , reinterpret_cast<uv_after_work_cb>(AsyncExecuteComplete)
4952 error       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4952 error ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, Nan::GetterCallback, Nan::SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, Nan::imp::Sig)’:
4952 error ../../nan/nan.h:2536:19: warning: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, v8::Local<v8::AccessorSignature>, v8::SideEffectType, v8::SideEffectType)’ is deprecated: Do signature check in accessor [-Wdeprecated-declarations]
4952 error  2536 |   tpl->SetAccessor(
4952 error       |   ~~~~~~~~~~~~~~~~^
4952 error  2537 |       name
4952 error       |       ~~~~         
4952 error  2538 |     , getter_
4952 error       |     ~~~~~~~~~      
4952 error  2539 |     , setter_
4952 error       |     ~~~~~~~~~      
4952 error  2540 |     , obj
4952 error       |     ~~~~~          
4952 error  2541 |     , settings
4952 error       |     ~~~~~~~~~~     
4952 error  2542 |     , attribute
4952 error       |     ~~~~~~~~~~~    
4952 error  2543 |     , signature);
4952 error       |     ~~~~~~~~~~~~   
4952 error In file included from /home/ivo/.cache/node-gyp/18.4.0/include/node/v8-function.h:15,
4952 error                  from /home/ivo/.cache/node-gyp/18.4.0/include/node/v8.h:33,
4952 error                  from /home/ivo/.cache/node-gyp/18.4.0/include/node/node.h:73,
4952 error                  from ../../nan/nan.h:54,
4952 error                  from ../src/main.cc:1:
4952 error /home/ivo/.cache/node-gyp/18.4.0/include/node/v8-template.h:838:8: note: declared here
4952 error   838 |   void SetAccessor(
4952 error       |        ^~~~~~~~~~~
4952 error In file included from ../../nan/nan.h:2884,
4952 error                  from ../src/main.cc:1:
4952 error ../../nan/nan_typedarray_contents.h: In constructor ‘Nan::TypedArrayContents<T>::TypedArrayContents(v8::Local<v8::Value>)’:
4952 error ../../nan/nan_typedarray_contents.h:34:43: error: ‘class v8::ArrayBuffer’ has no member named ‘GetContents’
4952 error    34 |       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
4952 error       |                                           ^~~~~~~~~~~
4952 error make: *** [fs_admin.target.mk:114: Release/obj.target/fs_admin/src/main.o] Error 1
4952 error gyp ERR! build error 
4952 error gyp ERR! stack Error: `make` failed with exit code: 2
4952 error gyp ERR! stack     at ChildProcess.onExit (/home/ivo/.nvm/versions/node/v18.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
4952 error gyp ERR! stack     at ChildProcess.emit (node:events:537:28)
4952 error gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:291:12)
4952 error gyp ERR! System Linux 5.17.15-76051715-generic
4952 error gyp ERR! command "/home/ivo/.nvm/versions/node/v18.4.0/bin/node" "/home/ivo/.nvm/versions/node/v18.4.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
4952 error gyp ERR! cwd /home/ivo/Documents/Projects/Studio/Molekule/code-repos/atom/script/node_modules/fs-admin
4952 error gyp ERR! node -v v18.4.0
4952 error gyp ERR! node-gyp -v v9.0.0
4952 error gyp ERR! not ok
4953 verbose exit 1
4954 timing npm Completed in 16885ms
4955 verbose unfinished npm timer reify 1656936631840
4956 verbose unfinished npm timer reify:build 1656936646128
4957 verbose unfinished npm timer build 1656936646130
4958 verbose unfinished npm timer build:deps 1656936646130
4959 verbose unfinished npm timer build:run:install 1656936646269
4960 verbose unfinished npm timer build:run:install:node_modules/fs-admin 1656936646327
4961 verbose code 1

Especially this bit:

Even more pared down error log snippet (click to expand)

4952 error In file included from ../../nan/nan.h:2884,
4952 error                  from ../src/main.cc:1:
4952 error ../../nan/nan_typedarray_contents.h: In constructor ‘Nan::TypedArrayContents<T>::TypedArrayContents(v8::Local<v8::Value>)’:
4952 error ../../nan/nan_typedarray_contents.h:34:43: error: ‘class v8::ArrayBuffer’ has no member named ‘GetContents’
4952 error    34 |       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
4952 error       |                                           ^~~~~~~~~~~

This line in particular:

4952 error ../../nan/nan_typedarray_contents.h:34:43: error: ‘class v8::ArrayBuffer’ has no member named ‘GetContents’

It looks like maybe you have outdated Nan? This same package builds fine for me against Node 18.4.0 even with npm 8.

(Although in general, I would recommend using npm 6, and the exact Node version corresponding to our Electron version, or the oldest supported LTS version of Node.)

Troubleshooting questions

Did you clone the repo recently, or did you clone a while ago?
What commit are you on? (git show --stat and give us the commit info from that?)
Have you made any uncommitted changes to the repo's package.json or package-lock.json files? (git status -uno)
Which repo/fork did you clone from? github.com/atom/atom? Or github.com/atom-community/atom? Another fork?
Have you tried doing script/clean then script/bootstrap again?

2 replies

DeeDeeG Jul 5, 2022

I think the most general solution would be to update to newer fs-admin package everywhere we can.

They have moved to node_addon_api --> N-API, also known as Node-API now. 🎉

See the release notes: https://github.com/atom/fs-admin/releases
(0.19.0 is when they made the switch to Node-API.)

Anything done in Node-API Should be a lot more fool-proof and just easier and nicer to deal with than Nan or similar.

IneptusMechanicus Jul 7, 2022
Author

So in regards to the troubleshoot questions

I cloned the repo recently and as of the time of writing I synced 15 minutes ago, so I'm using the version after the PR that was merged in @aminya's answer. That also yielded errors that I posted in the other thread.
Current commit hash from the command you posted : commit 695c213da5f4b0d30de15ec796a38bef849c0b2a
None whatsoever, a clean clone and script/bootstrap afterwards, and after I run script clean I hard reset the repo.
I didn't initially, but I did when I pulled the latest changes today (as of time of writing) and the latest error I posted above persists.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot bootstrap atom for development with Node 18 #427

{{title}}

Replies: 3 comments 12 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

Cannot bootstrap atom for development with Node 18 #427

IneptusMechanicus Jul 4, 2022

Replies: 3 comments · 12 replies

mauricioszabo Jul 4, 2022

aminya Jul 4, 2022 Maintainer

DeeDeeG Jul 7, 2022

mauricioszabo Jul 8, 2022

IneptusMechanicus Jul 8, 2022 Author

IneptusMechanicus Jul 8, 2022 Author

DeeDeeG Jul 8, 2022

DeeDeeG Jul 5, 2022

DeeDeeG Jul 5, 2022

IneptusMechanicus Jul 7, 2022 Author

IneptusMechanicus
Jul 4, 2022

Replies: 3 comments 12 replies

mauricioszabo
Jul 4, 2022

aminya
Jul 4, 2022
Maintainer

IneptusMechanicus Jul 8, 2022
Author

IneptusMechanicus Jul 8, 2022
Author

DeeDeeG
Jul 5, 2022

IneptusMechanicus Jul 7, 2022
Author