Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron #469

Open
AlexWayfer opened this issue Sep 13, 2022 · 2 comments
Open

Update Electron #469

AlexWayfer opened this issue Sep 13, 2022 · 2 comments

Comments

@AlexWayfer
Copy link

Summary

I see the same version of Electron as for mainstream, pretty outdated (EOL).

Please, update it.

Motivation

Atom started to crash with the latest stable version of glibc: https://bugs.archlinux.org/task/75902

Describe alternatives you've considered

--no-sandbox or --in-process-gpu flags, which don't look normal. Or locking an old version of glibc.

Additional context

We need for a good build of Atom Community in Arch Linux AUR!

@AlexWayfer
Copy link
Author

Atom Official non-merged PR: atom#23540

@icecream17
Copy link

icecream17 commented Sep 14, 2022

(Btw, for additional context, a separate Arch Linux build requires modifying build script. This would be done on top of electron update. I haven't described what such a feature might look like overall but here's the main issue for that: #419)

I think this issue is not about updating electron but rather atom#23036 (Crash on Linux on Start)

It's just that updating electron to at least v13 (note that v20 is latest, pr is v16, we're on v11.5.0) fixes this problem.

note on dependencies and the large amount of work needed to upgrade electron

Many of atom's dependencies are based on nan, and I think it would be easier/it's practically required to update to napi before trying to upgrade Electron because napi doesn't depend on v8 implementation details.

Another non-implementation-detail-possibility is literally migrating to WebAssembly, but that's a topic for debate about unsure amount of benefits and would require much more effort than napi.

Overall, it would be so nice if there was a way to automatically update stuff instead of doing such things manually. An ideal picture would be an automated electron upgrade.

Anyways, dependencies are only the beginning. But they're a decent chunk, I think upgrading can be separated into:

  • fix dependency errors (by updates)
  • don't use outdated apis/features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants