Fix Inconsistent Usage of consts in internal/fees
#1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoVillar
requested review from
aaronbuchwald and
joshua-kim
as code owners
internal/fees/manager_test.go
Outdated
| ) | ||
|
|
||
| func TestUnitsConsumed(t *testing.T) { | ||
| t.Run("empty manager consumes", func(t *testing.T) { |
There was a problem hiding this comment.
Can we change this to a table test instead of using t.Run in sequence? This is a bit of a non-standard pattern and I think we could make this a simple table test with an initial input, amount consumed, and expected result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
manager.lastConsumed()to useconsts.Int64Leninstead ofconsts.IntLenfor the size of timestamp