move to pigz -11 for better Zopfli compression #3005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telroshan
added
performance
ready for review
|
Closing per guidelines on unsolicited PRs. We can discuss changing the compression algorithm on the linked issue. I see the value, but we'd have to align on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move the final distribution step to use pigz -11 to apply Zopfli compression to reduce the size of the zipped minified distribution version. Saves a few % in file size at the one of small cpu cost. Added fall back to gzip if pigz not installed
Corresponding issue:
#2998
Testing
Tested to make sure the gz file was about .5k smaller and can be uncompressed fine with gzip -d
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded