improve softMatch to not retain state on morph if oldNode has id #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving softMatching so it handles not retaining state in error when morphing nodes with id's
If the old node has an id it could have some state that is important not to morph into a similar element so we can check for its ID and if either the new element has no ID or a different ID then we want to avoid morphing these nodes. Better to instead drop the node and re-add the new content instead.
Added new test with a checkbox with indeterminate state that will not be prevented from morphing and retaining invalid state.
Also had to fix two tests that had id's on the from side of the morph which would now prevent morphing