Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http browserify broken when sending a full node url object #27

Open
panthershark opened this issue Oct 8, 2013 · 2 comments
Open

http browserify broken when sending a full node url object #27

panthershark opened this issue Oct 8, 2013 · 2 comments

Comments

@panthershark
Copy link

var url = { 
    host: "localhost:8081",
    hostname: "localhost",
    href: "http://localhost:8081/api/foo?bar=baz",
    method: "GET",
    path: "/api/foo?bar=baz",
    pathname: "/api/foo",
    port: "8081",
    protocol: "http:",
    query: "bar=baz",
    search: "?bar=baz",
    slashes: true
  };
  var request = http.get(url, noop);
expected: "http://localhost:8081/api/foo?bar=baz"
actual:   "http://localhost:8081:8081/api/foo?bar=baz"

The url that is requested has the port in it 2 times. This is because of this line.
https://github.com/substack/http-browserify/blob/master/index.js#L7

I am finishing up a pull request to fix this where it will try host first, then hostname+port.

Please let me know if you have any input.

@SQUARE-WAVES
Copy link

+1.

@cappslock
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants