Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientRequest#setTimeout Support #49

Open
pvoisin opened this issue May 1, 2014 · 5 comments
Open

ClientRequest#setTimeout Support #49

pvoisin opened this issue May 1, 2014 · 5 comments

Comments

@pvoisin
Copy link

pvoisin commented May 1, 2014

First time I'm using Browserify, first test, and I stumble on that... ;)

It currently doesn't seem to support setTimeout.

@brandonrobertz
Copy link

Is there any interest in pulling in a fix for this, if write a pull request? I've ran into a situation where the lack of setTimeout is breaking some libraries when they are Browserified. The maintainer of one library in particular would prefer an upstream fix and I'm willing to write it if there's interest.

@dcousens
Copy link
Member

+1, would appreciate a fix for this as well

@brandonrobertz
Copy link

Just an update, I'm working on this and should have a PR for this issue this weekend.

@brandonrobertz
Copy link

Initial push on this. It's still just in my fork. I've verified that it works with my target library (https://github.com/freewil/node-bitcoin). Anyone else want to take a look?

https://github.com/brandonrobertz/http-browserify/compare/substack:master...master

@brandonrobertz
Copy link

#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants