-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response inherits from Stream instead of Stream.Readable (requiring request module browserify workaround) #81
Comments
Incomplete, because ._read still needs to be incompleted Ref browserify#81
+1 |
We (@goloroden and me) have written two small modules to stream JSON lines from a server to a client. Could be a very simple alternative to things like socket.io. The client run’s great inside node and as we’re big fans of browserify we’d like to make it work inside the browser as well. But we're currently facing some compatibility problems that seem to be related to this issue. When a client disconnects we’re using Do you have any plans to upgrade this module to the streams2 API? Maybe we can help to get this done. Any help or tips to get this issue resolved would be greatly appreciated. P.S.: Thanks for creating this awesome browserify ecosystem! |
+1 :-) |
For anybody having the same issues, @mattwagl and I have created a drop-in replacement for http-browserify that uses the streams2 API: http-browserify-2 |
On node.js, the HTTP response object (which is named IncomingMessage in node.js) inherits from Stream.Readable:
but in http-browserify, it only inherits from Stream:
This means the full stream API is not available as it is in Node, including the .resume() method. I believe this is the reason for this hack in the request module:
to improve compatibility would it be possible for http-browserify Response to inherit from Stream.Readable? (are there any other changes needed than changing the utils.inherits call?)
edit: Stream is old-style (pre-0.10); this amounts to converting http-browserify to Streams2
The text was updated successfully, but these errors were encountered: