-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chokes on ES6 modules. #93
Comments
Actually, note that the custom |
@anandthakker To clarify the traversing the ES6 modules point: it's outside the scope of Browserify until Node does it. |
@terinjokes 👍 makes sense. |
Hey! I think time has come ;) |
@glukki Node still does not support ES6 Modules. Browserify is an implementation of the Node module system for the web. With that in mind, it can't implement a module system that Node itself does not. |
@terinjokes sorry, my bad. I thought that node v5 already has import implemented :( |
Currently, running module-deps on source with ES6 module syntax throws
Error: Parsing file /blah/dee/dah.js 'import' and 'export' may appear only with 'sourceType: module' (4:0)
.The reason for this is that
acorn
, viadetective
, needs a{ecmaVersion: 6, sourceType: 'module'}
, but currently, there's no way to pass those options through.#63 would address this, although it would only be a superficial fix: module-deps still wouldn't actually traverse ES6 modules. I'm assuming ES6 modules are out of scope here?
Also: anything I could do to help get #63 merged?
The text was updated successfully, but these errors were encountered: