Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disabling the shuffling allocator by default #280

Open
cfallin opened this issue Oct 2, 2024 · 2 comments
Open

Consider disabling the shuffling allocator by default #280

cfallin opened this issue Oct 2, 2024 · 2 comments

Comments

@cfallin
Copy link
Member

cfallin commented Oct 2, 2024

A recent report by @d-sonuga indicates wildly differing data when measuring the impact of regalloc improvements on compile time depending on whether Sightglass's shuffling allocator is enabled or not: in his case, less prominent gains. On the other side, we've had instances in the past where we make improvements to Cranelift to reduce allocations and we see bigger gains under Sightglass that don't materialize into real savings in production.

The shuffling allocator was chosen in order to avoid measurement bias due to incidental details of memory layout. However, I'm concerned that in removing that source of error, we've also swamped the real signal, and are getting very misleading results. The end goal of benchmark measurement should be to drive a feedback loop that improves experience for end-users; to that end, it is likely better that we use the normal allocator by default, so we see gains in their proper proportions.

cc @fitzgen, @abrown, thoughts?

@fitzgen
Copy link
Member

fitzgen commented Oct 2, 2024

Yeah, seems fine by me.

Alternatively/additionally, if anyone wants to improve the perf of the shuffling allocator itself, that is also very welcome! There is no fundamental reason it should add so much overhead.

@abrown
Copy link
Collaborator

abrown commented Oct 4, 2024

Sounds ok to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants