Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible issue with API size parameter #1

Open
ddooley opened this issue Sep 3, 2021 · 2 comments
Open

possible issue with API size parameter #1

ddooley opened this issue Sep 3, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@ddooley
Copy link

ddooley commented Sep 3, 2021

We are submitting api status requests for jobs and including size parameter matching to our batch size. When we do that, we get back 1 less record than the batch size. We have to adjust size to be batch size + 1. So a batch size of 10 records means size parameter must be set to 11 to get back 10 records. Hence this works:

query = '?page=0&size=' + str(int(options.batch)+1) + '&sortDirection=ASC&sortField=submitterSampleId&submissionId=' + submission_id;

So I'm guessing you would want to adjust the conditional on size so this incrementing isn't needed?

@ghost ghost added the documentation Improvements or additions to documentation label Jun 8, 2022
@ghost ghost assigned b-f-chan Jun 9, 2022
@ghost
Copy link

ghost commented Jun 9, 2022

@b-f-chan can you please confirm this?

@ddooley
Copy link
Author

ddooley commented Jun 9, 2022

Note, this workaround is in our FastaUploader here: https://github.com/cidgoh/FastaUploader/blob/d1305d7f5840851427888592bfa39259a65070e8/fasta_uploader.py#L439

Regards,

Damion

@ghost ghost assigned ghost and unassigned b-f-chan Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants