Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LastBuildStatusTaskCondition only ever matches Success #310

Open
appel1 opened this issue Mar 16, 2022 · 0 comments
Open

LastBuildStatusTaskCondition only ever matches Success #310

appel1 opened this issue Mar 16, 2022 · 0 comments

Comments

@appel1
Copy link

appel1 commented Mar 16, 2022

IIntegrationResult.LastBuildStatus is only ever set if IntegrationRunner.GetModifications throws an exception. See

CruiseControl.NET/project/core/IntegrationRunner.cs

Line 87 in bcb43c3

result.LastBuildStatus = lastResult.HasSourceControlError ? lastResult.LastBuildStatus : lastResult.Status;

This means that for all other cases it will have the default value Success and can't be used in for example LastBuildStatusTaskCondition to trigger a task if the last build result was Failure.

Or am I missing something here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@appel1