Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check failures exit with 0 #225

Open
tomjkidd opened this issue Apr 5, 2019 · 0 comments
Open

Check failures exit with 0 #225

tomjkidd opened this issue Apr 5, 2019 · 0 comments

Comments

@tomjkidd
Copy link
Contributor

tomjkidd commented Apr 5, 2019

Talked briefly with @danielcompton privately, describing a situation I ran into in the wild using kibit in our CI. When check failures occur, their exceptions are caught and logged to stderr, but the exit code is 0. This makes it so that our tests pass, and we were unaware that there were things we needed to correct. I created a repo to provide the simplest project that demonstrates the issue (using a simple require statement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant