Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor_support.md: Remove emacs and Change coala/coala-eclipse#25 #655

Closed
wants to merge 14 commits into from
Closed

editor_support.md: Remove emacs and Change coala/coala-eclipse#25 #655

wants to merge 14 commits into from

Conversation

rahuldkjain
Copy link

coala/coala-eclipse#25 is replaced with coala/coala-eclipse#51.
coala/coala-emacs#11 is removed. emacs from the project body is also
removed.

Fixes #652

Naveenaidu
Naveenaidu suggested changes Aug 26, 2018
View reviewed changes
Copy link
Member

@Naveenaidu Naveenaidu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good.

Please change the commit message.
Removed should be changed to Remove
editor_support should be changed to editor_support.md.

You can edit the commit message by using git commit --amend

Please refer http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html#how-to-write-a-good-commit-message

@rahuldkjain rahuldkjain force-pushed the my-first-good-pull-request branch from 6661374 to 168bfb0 Compare August 26, 2018 07:49
@rahuldkjain rahuldkjain changed the title editor_support: Removed emacs editor_support.md: Remove emacs Aug 26, 2018
Naveenaidu
Naveenaidu approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@Naveenaidu Naveenaidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

li-boxuan
li-boxuan requested changes Aug 26, 2018
View reviewed changes
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit content looks good, but you may need to improve your commit message a bit. First, this is not a bug, so we should use close instead of fix. Second, your commit has done two thing, one is emacs removal, the other one is adding another issue. Your commit head only mentions one thing.

@rahuldkjain rahuldkjain force-pushed the my-first-good-pull-request branch from 168bfb0 to 7e483a7 Compare August 26, 2018 12:15
@rahuldkjain rahuldkjain changed the title editor_support.md: Remove emacs editor_support.md: Remove emacs and Change coala/coala-eclipse#25 Aug 26, 2018
@rahuldkjain
Copy link
Author

@li-boxuan Requested changes have been applied. Commit message has been fixed.

srivama
srivama reviewed Aug 26, 2018
View reviewed changes
Copy link
Contributor

@srivama srivama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@jayvdb
Copy link
Member

jayvdb commented Aug 28, 2018

Commit message still wrong see https://github.com/coala/projects/pull/655/commits

@rahuldkjain rahuldkjain force-pushed the my-first-good-pull-request branch from 67a601d to d7ab0cd Compare August 30, 2018 07:12
@rahuldkjain
Copy link
Author

@jayvdb Commit message modified. Please review again!

@jayvdb
Copy link
Member

jayvdb commented Sep 1, 2018

commit message still wildly wrong.

See https://coala.io/commit .

haeungun and others added 2 commits September 16, 2018 15:13
@haeungun
*.md: Fix file names of *.md into kebab style
4d72a69 
- Update the md files name which were
  snake case style to be the kebab style.
- Update .coafile to check whether a name of
  md files are the kebab style.

Closes coala#308
@srivama
app.js: Add redirect for pyflakes project
1d3d026 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
and also removes ending whitespace from project name

Fixes coala#573
@jayvdb
Copy link
Member

jayvdb commented Oct 20, 2018

ping @rahuldkjain

Hax7 and others added 2 commits October 20, 2018 18:50
@Hax7
adhikasp.md: Add pull requests commits into seperate activities
a582f79 
This commit adds an activity for every commit link instead of just the pull request link in adhikasp.md file

Closes coala#623
coala-will-apply-for-gsoc: Remove specific year
2600ca0 
This renames the file to coala-will-apply-for-gsoc.md.
It also changes 2018 to next year, as coala is likely
to participate every year.

Closes coala#672
utkarsh2102
utkarsh2102 suggested changes Oct 24, 2018
View reviewed changes
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
There are 14 commits presently.
You need to rebase it. For rebasing, refer this.
Also, you need to have a proper commit message. Refer this for the same.

“rahuldkjain” added 2 commits October 24, 2018 17:30
@jayvdb
Copy link
Member

jayvdb commented Aug 25, 2019

14 commits ; abandoned effort

@jayvdb jayvdb closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srivama srivama srivama left review comments

@utkarsh2102 utkarsh2102 utkarsh2102 requested changes

@li-boxuan li-boxuan li-boxuan requested changes

@Naveenaidu Naveenaidu Naveenaidu approved these changes

Assignees

@rahuldkjain rahuldkjain

Labels
difficulty/low difficulty/newcomer enhancement importance/low importance/medium initiatives/gci process/wip size/XL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cohesive Editor Support: update related issues