-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rdkit to global pinning #5719
Comments
cc @greglandrum for awareness. Their ABI version is |
Yeah, that hasn't ever changed since we do not attempt to track ABI versions or maintain ABI compatibility. The assumption is that you'll probably need to recompile code that depends on the libraries when the version of the underlying library changes We do try and avoid actually breaking code, and if this happens it will only be in one of the twice-yearly major releases, but now that we're adding new features in minor releaes, it is possible that a minor release can contain new functions/overloads and/or that new arguments (with default values so that existing code does not break) may be added to existing functions. |
It's OK not to have a real ABI, but once packages start depending on |
There's quite a large number of packages depending on
rdkit
; even moreso given thatrdkit
contains a whole bunch of libraries:list of libraries
From the
.so.1
+ CalVer I'm not actually sure whether we'd even need to rebuild for every major version (==year); this can be circumvented with a sover-style package if necessary. For now though, I'd at least want to capture this correctly, as not having this pinned is forcing the solver into some weird contortions in some places.CC @conda-forge/rdkit @conda-forge/core
The text was updated successfully, but these errors were encountered: