Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.2 is broken? (iOS) #196

Open
TheRohitSharma opened this issue Oct 1, 2018 · 14 comments
Open

0.5.2 is broken? (iOS) #196

TheRohitSharma opened this issue Oct 1, 2018 · 14 comments

Comments

@TheRohitSharma
Copy link

TheRohitSharma commented Oct 1, 2018

I had to revert to 0.5.1 to get my build using React Native v0.55.4 to work with this module. I kept getting an error regarding Fabric being undefined when I attempted to use Fabric.Answers. Once I reverted to 0.5.1, it built just fine.

Not a big deal for me, but figured I'd give a heads up.

@sibelius
Copy link
Contributor

sibelius commented Oct 1, 2018

can you share your error stacktrace?

does this happen on android as well?

cocoapods or react-native link?

@TheRohitSharma
Copy link
Author

TheRohitSharma commented Oct 1, 2018

2018-10-01 10:44:11.068 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Cannot read property 'Answers' of undefined 2018-10-01 10:44:11.090 [fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Module AppRegistry is not a registered callable module (calling runApplication)

Haven't had time yet to test on Android. Using exact same code and settings that work without a problem using 0.5.1. Xcode version is 9.4.1.

Using react-native link

@jgcmarins
Copy link

react-native link react-native-fabric
or just react-native link?
it is safer to specify which lib you are trying to link
sometimes react-native link can duplicate old links, if you are not passing which lib you want to link

@TheRohitSharma
Copy link
Author

May not have unlinked before relinking. :/ Trying again.

@jgcmarins
Copy link

take a look at your settings.gradle file

@IndianAg0711
Copy link

0.5.2 has an issue in iOS where the header paths specified in the SMXXCrashlytics.xcodeproj is not being set correectly. A fix has been merged into master, but a new version of the package has not been released on NPM yet. reverting back to 0.5.1 or using the master branch of this repo in your package.json file should work.

@sibelius
Copy link
Contributor

sibelius commented Oct 2, 2018

in which commit?

@IndianAg0711
Copy link

@sibelius I'm looking through your commits and can't find anything recent that touched framework search paths directly - it was consistently setting a recursive search path that I had to change for the project to build correctly each time I installed 0.5.2, and when I attempted to use the master branch the search path was set correctly. Sorry I can't provide more info. Will try to dig deeper when I have time.

@sibelius
Copy link
Contributor

sibelius commented Oct 4, 2018

maybe releasing another release can fix this?

@IndianAg0711
Copy link

possibly 🤞

@TheRohitSharma
Copy link
Author

TheRohitSharma commented Oct 5, 2018

I haven't had a chance to look either, but i did notice that running react-native link react-native-fabric on v0.5.2 just adds to my podfile instead of actually linking as it does <v0.5.2. This also causes issues because afterwards, pod install ends up installing React as well, at which point I have two copies of React which causes errors.

@gedeagas
Copy link

gedeagas commented Nov 1, 2018

Have the same exact problem with @TheRohitSharma

@bdelville
Copy link

I reproduce the problem on Android

@diegorribeiro
Copy link

diegorribeiro commented Dec 11, 2018

0.5.2 has an issue in iOS where the header paths specified in the SMXXCrashlytics.xcodeproj is not being set correectly. A fix has been merged into master, but a new version of the package has not been released on NPM yet. reverting back to 0.5.1 or using the master branch of this repo in your package.json file should work.

0.5.2 Works fine, but change the import to this :
import * as FABRIC from 'react-native-fabric'

AND

FABRIC.Answers.logContentView('Home', 'Simple view', 'page-view');

Works.. 0/


import FABRIC from 'react-native-fabric' doesn't works for me in latest version (0.5.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants