-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS values don't cause cascading updates #95
Comments
Are you using I ran into that with https://github.com/tivac/modular-css/blob/master/src/browserify.js#L123-L127 |
Ahh interesting, yep I am using browserify/watchify via the CLI |
Thanks for reporting it, definitely a bug. And thanks for the notes @tivac I haven't looked at fixing this in There are still some changes I want to make, and then we'll consider whether it will replace Also works great with hot reloading (via |
hmm seems like it never detects a change to produce the |
Interesting, I haven't used browsersync. @tj are you using browsersync in a way that wouldn't also be be suitably solved by browserify-hmr? |
Is browserify-hmr supposed to support CSS? I was using it for a while but ended up removing it since only it only supports stateful components and I didn't want to sprinkle the 'ud' module all over. I just thought that when you edit the css that it would save out to whatever your |
I've got the same issue here. I need to do an additional save on one of the involved CSS files before the result of a changed value in colors.css actually streams to the browser with BrowserSync. Let me know if there are any workarounds! 😄 |
Quick status update, I've got a solution for this working locally that I hope to put into a PR, once I've checked it a bit more thoroughly. So far |
@joshwnj What is the status on that PR? |
@spenserw ow, it's been a while hasn't it :P Life got suddenly busy. I'll put some more heat on this one. |
rebuilds dependent css modules so that changes to values propagate (fixes #95)
@joshwnj Will try as soon as I get a chance, thanks for the quick turnaround time! |
Not sure where to report, but I'm seeing that only files that you edit are receiving value (https://github.com/css-modules/postcss-modules-values) changes. Is this the intended behaviour or possibly a bug? Took me a few minutes to realize what was going on, results popping in minutes later. Also if you have a file like colors.css, edit a value, nothing sees the change, until you edit those files.
I don't know the underlying mechanism for browserify etc so I can't comment on what would be going on, but it seems broken.
cheers
The text was updated successfully, but these errors were encountered: