Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of string handling #15

Open
danielcompton opened this issue Jun 29, 2017 · 1 comment
Open

Improve performance of string handling #15

danielcompton opened this issue Jun 29, 2017 · 1 comment

Comments

@danielcompton
Copy link
Contributor

The string.split and string/includes? calls get very expensive when there are a large number of them. We should look into a cheaper way of doing this, perhaps by creating another Reagent function which returns a vector of the component hierarchy, rather than a string.

@danielcompton
Copy link
Contributor Author

We have a memoize over the component-path which amortises the cost, but it would probably be better to operate over data instead of splitting strings if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant