-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Move gc data protection to R side #11104
base: master
Are you sure you want to change the base?
Conversation
Let me try to create a prototype for the #11088 and see how this should work. I need to store the categories somewhere. |
Should we revert #11092 before applying this PR? The previous one seems redundant now. |
It is undoing the changes from it already. But it leaves me wondering: what's the difference between Is |
The In addition, the former applies to both |
If you meant things like labels and weights, no, they don't need any protection. |
Thanks, modified the PR to not keep those protected after setting them. |
Will take a deeper look tomorrow. |
ref #9810
ref #11092 (comment)
This PR moves the logic for protection of R data from the garbage collector towards the R side.
I'm not sure whether data holding fields of the DMatrix also needs to be kept protected after setting it in the proxy dmatrix, but this PR does so just in case.