Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C API tutorial #11131

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Update C API tutorial #11131

merged 1 commit into from
Dec 31, 2024

Conversation

ayoub317
Copy link
Contributor

Set C++17 as the minimum required version for the tutorial

The current code relies on features introduced in C++17, such as nested namespaces and std::is_same_v.
Without C++17, the compilation results in warnings like:
"nested namespace definition is a C++17 extension; define each namespace separately", and errors like:
"no template named 'is_same_v' in namespace 'std'".
To fix this, I've set C++17 as the minimum required version to ensure compatibility.

Additionally, I made a small fix to the matrix initialization in the tutorial.

@trivialfis
Copy link
Member

Hi, thank you for the PR. I think the tutorial itself is C-only and doesn't need c++ version configuration.

@ayoub317
Copy link
Contributor Author

ayoub317 commented Dec 29, 2024

Hello, my bad ! Thank you for pointing that out.

I’ve updated the review to include only the small bug fix.

@trivialfis trivialfis merged commit 15a1b2f into dmlc:master Dec 31, 2024
52 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants