Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support dark mode for zoom-image plugin #2508

Open
wohenbushuang opened this issue Nov 6, 2024 · 5 comments
Open

FR: Support dark mode for zoom-image plugin #2508

wohenbushuang opened this issue Nov 6, 2024 · 5 comments

Comments

@wohenbushuang
Copy link

Feature request

Problem or desire

Support dark mode for zoom-image plugin

Proposal

Support dark mode for zoom-image plugin

Implementation

Support dark mode for zoom-image plugin, instead of fixed white background

@BanerjeeAgniva
Copy link

@sy-records Hey I am new to open-source and coding, can you tell me what files I need to look into for this issue, thanks!

@sy-records
Copy link
Member

Hi, @BanerjeeAgniva

You can see https://github.com/docsifyjs/docsify/blob/develop/src/plugins/zoom-image.js

In Dark Mode, a few style changes will do the trick.

@ZEviod
Copy link

ZEviod commented Dec 23, 2024

Hello @sy-records, I’d like to work on adding this feature.
If yes, could you please clarify a few details to ensure alignment?

->Should the dark mode support be automatic (based on system preferences) or configurable via plugin options?
->Are there any existing guidelines, color schemes, or design patterns for dark mode in this project?
->Would you prefer dark mode styling to be implemented using CSS variables, a separate stylesheet, or another approach?

@sy-records
Copy link
Member

Should the dark mode support be automatic (based on system preferences) or configurable via plugin options?

Automated, judgment by media query. prefers-color-scheme: dark

Are there any existing guidelines, color schemes, or design patterns for dark mode in this project?

We support dark mode in the new version, see https://github.com/docsifyjs/docsify/deployments/Preview , https://docsify-preview-hshwchgkk-docsifyjs.vercel.app/preview/#/themes?id=themes

Would you prefer dark mode styling to be implemented using CSS variables, a separate stylesheet, or another approach?

I think adding some styling to zoom-image.js will do the trick!

@trusktr
Copy link
Member

trusktr commented Dec 25, 2024

@jhildenbiddle any preferences here that may be best aligned with Docsify and docsify-themeable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants