-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Support dark mode for zoom-image plugin #2508
Comments
@sy-records Hey I am new to open-source and coding, can you tell me what files I need to look into for this issue, thanks! |
Hi, @BanerjeeAgniva You can see https://github.com/docsifyjs/docsify/blob/develop/src/plugins/zoom-image.js In |
Hello @sy-records, I’d like to work on adding this feature. ->Should the dark mode support be automatic (based on system preferences) or configurable via plugin options? |
Automated, judgment by media query.
We support dark mode in the new version, see https://github.com/docsifyjs/docsify/deployments/Preview , https://docsify-preview-hshwchgkk-docsifyjs.vercel.app/preview/#/themes?id=themes
I think adding some styling to zoom-image.js will do the trick! |
@jhildenbiddle any preferences here that may be best aligned with Docsify and docsify-themeable? |
Feature request
Problem or desire
Support dark mode for zoom-image plugin
Proposal
Support dark mode for zoom-image plugin
Implementation
Support dark mode for zoom-image plugin, instead of fixed white background
The text was updated successfully, but these errors were encountered: