Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript+Static Web Assets integration #34165

Open
javiercn opened this issue Nov 18, 2024 · 3 comments · May be fixed by #34175
Open

Typescript+Static Web Assets integration #34165

javiercn opened this issue Nov 18, 2024 · 3 comments · May be fixed by #34175
Assignees
@Rick-Anderson
Labels
aspnet-core/svc razor-pages/subsvc Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@javiercn
Copy link
Member

javiercn commented Nov 18, 2024 •
edited by dotnetrepoman bot
Loading

Description

CompileTypeScript needs to be updated to CompileTypeScriptWithTSConfig as the target has changed

Improve this section to include removing the content from the wwwroot folder in the typescript section.

<ItemGroup>
  <Content Remove="wwwroot\<<path-to-typescript-outputs>>" />
</ItemGroup>

Page URL

https://learn.microsoft.com/en-us/aspnet/core/razor-pages/ui-class?view=aspnetcore-9.0&tabs=visual-studio#typescript-integration

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/razor-pages/ui-class.md

Document ID

fd116d00-0dc7-efaf-c714-34d77b345a05

Article author

@tdykstra

Related Issues
@javiercn javiercn added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Nov 18, 2024
@javiercn javiercn mentioned this issue Nov 18, 2024
Closed
1 task
@Rick-Anderson Rick-Anderson self-assigned this Nov 19, 2024
@Rick-Anderson
Copy link
Contributor

@guardrex you can take this if you like, otherwise I'll fix.

@Rick-Anderson Rick-Anderson linked a pull request Nov 19, 2024 that will close this issue
Open
@guardrex
Copy link
Collaborator

I had already gone to 🛌 when you remarked, and I see you have the PR for it.

@javiercn
Copy link
Member Author

javiercn commented Nov 19, 2024 •
edited
Loading

We also need this target instead of <Content Remove="wwwroot\<<path-to-typescript-outputs>>" /> and both CompileTypeScript and CompileTypeScriptWithTSConfig are needed, I believe.

+    <Target Name="RemoveDuplicateTypeScriptOutputs" BeforeTargets="GetTypeScriptOutputForPublishing">
+      <ItemGroup>
+        <Content Remove="@(GeneratedJavaScript)" />
+      </ItemGroup>
+    </Target>

@Rick-Anderson Rick-Anderson moved this from 🔖 Ready to 👀 In review in dotnet/AspNetCore.Docs December 2024 sprint Dec 2, 2024
@dotnetrepoman dotnetrepoman bot added mapQuest clean move and removed mapQuest clean move labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rick-Anderson Rick-Anderson

Labels
aspnet-core/svc razor-pages/subsvc Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
dotnet/AspNetCore.Docs December 2024 sprint
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typescript/static/assets/ra/7 dotnet/AspNetCore.Docs
3 participants
@guardrex @Rick-Anderson @javiercn