Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vs17.13] Update dependencies from nuget/nuget.client #11141

Closed
wants to merge 2 commits into from
Closed

[vs17.13] Update dependencies from nuget/nuget.client #11141

wants to merge 2 commits into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

  • Subscription: 4e9203e9-e24c-4fa3-a94e-550067b2a520
  • Build: 6.13.0.95
  • Date Produced: December 12, 2024 2:06:50 AM UTC
  • Commit: f6f635eebfdddd88b8856f830e0f0ffa168540eb
  • Branch: dev

@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
2ca259a 
…6.13.0.95

NuGet.Build.Tasks
 From Version 6.13.0-rc.93 -> To Version 6.13.0-rc.95
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner December 13, 2024 12:50
@rainersigwald
Copy link
Member

@JanKrivanek as a rule we shouldn't be taking these updates to release branches. Is this one special?

@dkurepa dkurepa mentioned this pull request Dec 18, 2024
Open
@JanKrivanek
Copy link
Member

@JanKrivanek as a rule we shouldn't be taking these updates to release branches. Is this one special?

My bad - I'm unaware of such rule. Can you please point me?
Should then the subscriptions be created in disabled state for release branches? Or anything we can improve in the checklist https://github.com/dotnet/msbuild/blob/main/documentation/release-checklist.md#adjust-darc-channels-and-subscriptions?

@JanKrivanek
Copy link
Member

Discussed with @YuliiaKovalova - it sounds like we only want the keep bumping SBRP and Arcade; otherwise Roslyn and Nuget (or any possible future product dependencies) should be bumped only if this is needed by SDK or VS. Is that correct?

This is suggested checklist update:

5278e70#diff-61ca3e227e41a59774153096623e36063335a5f1b801021995a92efcaf55ce80R61

This was referenced Dec 23, 2024
Closed
Closed
@JanKrivanek
Copy link
Member

Closign now

@dotnet-maestro dotnet-maestro bot deleted the darc-vs17.13-9c403ef6-d479-4abc-a8d0-d6cfb3c554ab branch December 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainersigwald @JanKrivanek