Add System.Diagnostics.DiagnosticSource.9.0.0 to SourceBuild

[JanProvaznik]

We need to add System.Diagnostics.DiagnosticSource.9.0.0 to SourceBuild to enable instrumenting using System.Diagnostics.Activities which can then be used in our VS telemetry or via a hook.

Without the package the MSBuild Telemetry WIP does not compile in CI: https://github.com/dotnet/msbuild/pull/11084/checks?check_run_id=34598645353

[baronfel]

Why is this needed? I thought System.Diagnostics and related types were part of the Base Class Library?

[JanProvaznik]

It's in .NET 9, but not in .NET Standard 2.0 . We target standard in Microsoft.Build.Framework

[JanKrivanek]

There is a 8.0 already:

https://github.com/dotnet/source-build-reference-packages/tree/main/src/referencePackages/src/system.diagnostics.diagnosticsource

It looks like the 9.0 version will anyway eventually be needed for FSharp

@MichaelSimons - can we request this to be added (System.Diagnostics.DiagnosticSource.9.0.0), or should we just self service produce a PR?

[MichaelSimons]

Is #11084 going to flow into a 9.0 sdk? If so you can't add the a current assembly for that branch into SBRP. You would simply need to declare a dependency in Version.Details.xml. This will allow source-build to use the live built version of the dependency when building msbuild.

[JanKrivanek]

So basicaly just?:

darc add-dependency --name System.Diagnostics.DiagnosticsSource -v 9.0.0 -t product -r https://github.com/dotnet/runtime

This is btw. for the VNext (10.0) - no plans to flow to 9.0 sdk

[MichaelSimons]

This is btw. for the VNext (10.0) - no plans to flow to 9.0 sdk

Then in that case, yes, it should just be added to SBRP. The repo is self-service. The instructions to add new packages is here.