Use correct product version in SPC in servicing #110980
Open
+19
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed we missed to port the version changes from dotnet#108899 (review) to main. This does that so we embed the correct version number into System.Private.CoreLib even during servicing. I simplified the source generator to pass the ProductVersion msbuild property into the compilation instead of using reflection on the generator assembly.
akoeplinger
requested review from
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
akoeplinger
added
area-System.Runtime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
We now always have the stabilized product version.
This was referenced Dec 28, 2024
jkotas
reviewed
Dec 29, 2024
| @@ -196,17 +196,10 @@ public void VerifyFrameworkDescriptionContainsCorrectVersion() | |||
| return; | |||
|
|
|||
| Assert.DoesNotContain("+", version); // no git hash | |||
| Assert.DoesNotContain("-", version); // no preview suffix | |||
There was a problem hiding this comment.
It was possible to identify preview or private builds from the FrameworkDescription string before this change. This feature has been useful for diagnostics. Should this feature be preserved?
There was a problem hiding this comment.
@jkotas yeah, we seem to have other tests that make that assumption too so it was easier to restore that behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we missed to port the version changes from #108899 (review) to main. This does that so we embed the correct version number for
FrameworkDescriptioninto System.Private.CoreLib even during servicing when using the stabilized version.I simplified the source generator to pass the InformationalVersion msbuild property into the compilation instead of using reflection on the generator assembly.