Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Review App WebSocket Connection Fails 😢 #316

Open
nelsonic opened this issue Feb 23, 2023 · 0 comments
Open

Chore: Review App WebSocket Connection Fails 😢 #316

nelsonic opened this issue Feb 23, 2023 · 0 comments
Assignees
@SimonLab
Labels
chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code help wanted If you can help make progress with this issue, please comment! T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

Websockets do not work on the Review Apps: https://mvp-pr-314.fly.dev/
image

app-240a58de09e196d2…fc67974c.js?vsn=d:1 WebSocket connection 
to 'wss://mvp-pr-314.fly.dev/live/websocket?_csrf_token=BTElC05hBCYAJh8iE7974c.js%3Fvsn%3Dd&_mounts=0&_live_referer=undefined&vsn=2.0.0' failed:

I suspect that this might be due to the PHX_HOST not being set correctly ...

mvp/config/runtime.exs

Line 51 in cd0b132

host = System.get_env("PHX_HOST") || "example.com"

Would be very good to get this fixed soon so that we can fully test the Review Apps. 🙏
@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! technical A technical issue that requires understanding of the code, infrastructure or dependencies chore a tedious but necessary task often paying technical debt T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written elixir Pull requests that update Elixir code labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code help wanted If you can help make progress with this issue, please comment! T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab