[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` (#202830) #205231

pgayvallet · 2024-12-29T09:11:22Z

Backport

This will backport the following commits from main to 8.x:

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team (#202830)

Questions ?

Please refer to the Backport tool documentation

…ux-infra_services-team` (elastic#202830) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 6 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/apm-data-access-plugin` | `x-pack/solutions/observability/plugins/apm_data_access` | | `@kbn/apm-plugin` | `x-pack/solutions/observability/plugins/apm` | | `@kbn/inventory-plugin` | `x-pack/solutions/observability/plugins/inventory` | | `@kbn/metrics-data-access-plugin` | `x-pack/solutions/observability/plugins/metrics_data_access` | | `@kbn/profiling-data-access-plugin` | `x-pack/solutions/observability/plugins/profiling_data_access` | | `@kbn/profiling-plugin` | `x-pack/solutions/observability/plugins/profiling` | #### 6 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/apm-data-view` | `src/platform/packages/shared/kbn-apm-data-view` | | `@kbn/apm-types` | `x-pack/solutions/observability/packages/kbn-apm-types` | | `@kbn/apm-utils` | `src/platform/packages/shared/kbn-apm-utils` | | `@kbn/lens-embeddable-utils` | `src/platform/packages/shared/kbn-lens-embeddable-utils` | | `@kbn/profiling-utils` | `src/platform/packages/shared/kbn-profiling-utils` | | `@kbn/shared-svg` | `src/platform/packages/shared/kbn-shared-svg` | <details > <summary>Updated references</summary> ``` ./.buildkite/ftr_oblt_stateful_configs.yml ./.buildkite/scripts/steps/functional/apm_cypress.sh ./.buildkite/scripts/steps/functional/inventory_cypress.sh ./.buildkite/scripts/steps/functional/profiling_cypress.sh ./.eslintrc.js ./.github/paths-labeller.yml ./.gitignore ./docs/developer/plugin-list.asciidoc ./oas_docs/overlays/alerting.overlays.yaml ./oas_docs/scripts/merge_ess_oas.js ./oas_docs/scripts/merge_serverless_oas.js ./package.json ./packages/kbn-eslint-plugin-i18n/helpers/get_i18n_identifier_from_file_path.test.ts ./packages/kbn-eslint-plugin-telemetry/helpers/get_app_name.test.ts ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./src/dev/precommit_hook/casing_check_config.js ./src/dev/storybook/aliases.ts ./src/platform/packages/shared/kbn-lens-embeddable-utils/jest.config.js ./src/platform/packages/shared/kbn-profiling-utils/jest.config.js ./src/platform/packages/shared/kbn-shared-svg/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/shared/ml/aiops_log_rate_analysis/queries/fetch_index_info.ts ./x-pack/platform/packages/shared/ml/aiops_log_rate_analysis/queries/fetch_significant_term_p_values.ts ./x-pack/platform/packages/shared/ml/aiops_log_rate_analysis/queries/fetch_top_terms.ts ./x-pack/platform/plugins/private/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts ./x-pack/solutions/observability/plugins/apm/common/rules/apm_rule_types.ts ./x-pack/solutions/observability/plugins/apm/dev_docs/apm_queries.md ./x-pack/solutions/observability/plugins/apm/dev_docs/linting.md ./x-pack/solutions/observability/plugins/apm/dev_docs/local_setup.md ./x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md ./x-pack/solutions/observability/plugins/apm/dev_docs/testing.md ./x-pack/solutions/observability/plugins/apm/dev_docs/updating_functional_tests_archives.md ./x-pack/solutions/observability/plugins/apm/dev_docs/vscode_setup.md ./x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md ./x-pack/solutions/observability/plugins/apm/jest.config.js ./x-pack/solutions/observability/plugins/apm/scripts/infer_route_return_types/index.ts ./x-pack/solutions/observability/plugins/apm/scripts/precommit.js ./x-pack/solutions/observability/plugins/apm/scripts/telemetry/main.ts ./x-pack/solutions/observability/plugins/apm_data_access/jest.config.js ./x-pack/solutions/observability/plugins/exploratory_view/common/annotations.ts ./x-pack/solutions/observability/plugins/inventory/README.md ./x-pack/solutions/observability/plugins/inventory/jest.config.js ./x-pack/solutions/observability/plugins/metrics_data_access/jest.config.js ./x-pack/solutions/observability/plugins/observability/common/annotations.ts ./x-pack/solutions/observability/plugins/profiling/README.md ./x-pack/solutions/observability/plugins/profiling/e2e/README.md ./x-pack/solutions/observability/plugins/profiling/jest.config.js ./x-pack/solutions/observability/plugins/profiling_data_access/jest.config.js ./x-pack/solutions/security/plugins/security_solution/server/utils/build_query/calculate_timeseries_interval.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/shared/kbn-apm-data-view/tsconfig.json:2 src/platform/packages/shared/kbn-apm-utils/tsconfig.json:2 src/platform/packages/shared/kbn-lens-embeddable-utils/jest.config.js:12 src/platform/packages/shared/kbn-lens-embeddable-utils/tsconfig.json:2 src/platform/packages/shared/kbn-profiling-utils/jest.config.js:12 src/platform/packages/shared/kbn-profiling-utils/tsconfig.json:2 src/platform/packages/shared/kbn-shared-svg/jest.config.js:12 src/platform/packages/shared/kbn-shared-svg/tsconfig.json:2 x-pack/solutions/observability/packages/kbn-apm-types/tsconfig.json:2 x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md:17 x-pack/solutions/observability/plugins/apm/dev_docs/telemetry.md:22 x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:130 x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:222 x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:78 x-pack/solutions/observability/plugins/apm/dev_docs/testing.md:96 x-pack/solutions/observability/plugins/apm/dev_docs/vscode_setup.md:42 x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md:3 x-pack/solutions/observability/plugins/apm/ftr_e2e/tsconfig.json:2 x-pack/solutions/observability/plugins/apm/jest.config.js:12 x-pack/solutions/observability/plugins/apm/scripts/infer_route_return_types/index.ts:125 x-pack/solutions/observability/plugins/apm/scripts/precommit.js:15 x-pack/solutions/observability/plugins/apm/scripts/precommit.js:33 x-pack/solutions/observability/plugins/apm/scripts/precommit.js:38 x-pack/solutions/observability/plugins/apm/scripts/precommit.js:50 x-pack/solutions/observability/plugins/apm/scripts/shared/read_kibana_config.ts:16 x-pack/solutions/observability/plugins/apm/tsconfig.json:2 x-pack/solutions/observability/plugins/apm/tsconfig.json:7 x-pack/solutions/observability/plugins/apm_data_access/jest.config.js:12 x-pack/solutions/observability/plugins/apm_data_access/tsconfig.json:2 x-pack/solutions/observability/plugins/apm_data_access/tsconfig.json:6 x-pack/solutions/observability/plugins/inventory/e2e/tsconfig.json:2 x-pack/solutions/observability/plugins/inventory/jest.config.js:10 x-pack/solutions/observability/plugins/inventory/tsconfig.json:2 x-pack/solutions/observability/plugins/inventory/tsconfig.json:7 x-pack/solutions/observability/plugins/metrics_data_access/jest.config.js:10 x-pack/solutions/observability/plugins/metrics_data_access/tsconfig.json:2 x-pack/solutions/observability/plugins/metrics_data_access/tsconfig.json:6 x-pack/solutions/observability/plugins/profiling/README.md:52 x-pack/solutions/observability/plugins/profiling/e2e/README.md:3 x-pack/solutions/observability/plugins/profiling/e2e/tsconfig.json:11 x-pack/solutions/observability/plugins/profiling/e2e/tsconfig.json:2 x-pack/solutions/observability/plugins/profiling/jest.config.js:10 x-pack/solutions/observability/plugins/profiling/tsconfig.json:2 x-pack/solutions/observability/plugins/profiling_data_access/jest.config.js:12 x-pack/solutions/observability/plugins/profiling_data_access/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 8899fb8) # Conflicts: # .buildkite/ftr_oblt_stateful_configs.yml # .github/CODEOWNERS # oas_docs/scripts/merge_serverless_oas.js # package.json # src/dev/storybook/aliases.ts # tsconfig.base.json # x-pack/.i18nrc.json # x-pack/plugins/observability_solution/apm/public/components/app/mobile/service_overview/geo_map/map_layers/style_color_params.ts # x-pack/plugins/observability_solution/apm/server/lib/deprecations/types.ts # x-pack/plugins/telemetry_collection_xpack/schema/xpack_observability.json # x-pack/solutions/observability/plugins/apm/ftr_e2e/README.md # x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/e2e/service_overview/otel_service_overview_and_transactions.cy.ts # x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/fixtures/synthtrace/sendotlp.ts # x-pack/solutions/observability/plugins/apm/public/components/app/mobile/service_overview/geo_map/map_layers/style_color_params.ts # x-pack/solutions/observability/plugins/apm/public/hooks/use_theme.tsx # x-pack/solutions/observability/plugins/apm/server/deprecations/__snapshots__/apm_user_role.test.ts.snap # x-pack/solutions/observability/plugins/apm/server/deprecations/apm_user_role.test.ts # x-pack/solutions/observability/plugins/apm/server/deprecations/apm_user_role.ts # x-pack/solutions/observability/plugins/apm/server/deprecations/deprecations.test.ts # x-pack/solutions/observability/plugins/apm/server/lib/deprecations/index.ts # x-pack/solutions/observability/plugins/apm/server/lib/deprecations/types.ts # x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/version_mismatch/index.ts # x-pack/solutions/security/plugins/security_solution_serverless/server/common/services/index.ts

github-actions · 2024-12-29T09:11:37Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

github-actions · 2024-12-29T09:11:37Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-12-29T18:34:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 0b16f4c
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-205231-0b16f4c8074f

Failed CI Steps

FTR Configs #37

Test Failures

[job] [logs] FTR Configs #37 / ObservabilityApp Observability Rules page Create rules flyout "after each" hook for "Should allow the user to select consumers when creating ES query rules"
[job] [logs] FTR Configs #37 / ObservabilityApp Observability Rules page Create rules flyout Should allow the user to select consumers when creating ES query rules

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.5MB	3.5MB	-12.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`apm`	68	52	-16
`profiling`	18	17	-1
total			-17

Total ESLint disabled count

id	before	after	diff
`apm`	81	65	-16
`profiling`	21	20	-1
total			-17

History

💔 Build #263250 failed 31265c6
💔 Build #263246 failed 0d4d420

pgayvallet requested a review from kibanamachine as a code owner December 29, 2024 09:11

pgayvallet added the backport label Dec 29, 2024

pgayvallet enabled auto-merge (squash) December 29, 2024 09:11

botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 29, 2024

pgayvallet mentioned this pull request Dec 29, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team #202830

Merged

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

0d4d420

gsoldevila approved these changes Dec 29, 2024

View reviewed changes

pgayvallet added 3 commits December 29, 2024 17:28

move forgotten stuff

3ca4eff

add missing styled component

31265c6

updating telemetry mappings

0b16f4c

pgayvallet merged commit 8a99929 into elastic:8.x Dec 29, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` (#202830) #205231

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` (#202830) #205231

pgayvallet commented Dec 29, 2024

github-actions bot commented Dec 29, 2024

github-actions bot commented Dec 29, 2024

elasticmachine commented Dec 29, 2024 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team (#202830) #205231

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-infra_services-team (#202830) #205231

Conversation

pgayvallet commented Dec 29, 2024

Backport

Questions ?

github-actions bot commented Dec 29, 2024

github-actions bot commented Dec 29, 2024

🤖 GitHub comments

elasticmachine commented Dec 29, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` (#202830) #205231

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-infra_services-team` (#202830) #205231

elasticmachine commented Dec 29, 2024 •

edited

Loading