Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradualizer to ci #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add gradualizer to ci #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
992091c
Add gradualizer plugin
aleklisi Oct 4, 2019
84de57b
Add gradualizer job to travis build
aleklisi Oct 4, 2019
3b9b56f
Replace with in rebar.lock
aleklisi Oct 4, 2019
86b859c
Add running branches starting name with to CI
aleklisi Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ otp_release:
branches:
only:
- master
- /BUILD.*/

addons:
apt:
Expand All @@ -18,6 +19,7 @@ install: rebar3 compile
script:
- rebar3 xref
- rebar3 dialyzer
- rebar3 gradualizer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we'd need this one in Travis's allow_failures block, like Gradualizer's team themselves have here: https://github.com/josefs/Gradualizer/blob/97e8a9363fb21538c4a7223278ab59499ca2be19/.travis.yml#L9

I think that we could change quite a bit this travis.yml actually, to something like

sudo: false

language: erlang
otp_release:
  - 22.1
  - 21.3

branches:
  only:
    - master
    - /BUILD.*/

addons:
  apt:
    packages:
      - libexpat1-dev

install: rebar3 compile
script:
  - rebar3 xref
  - rebar3 dialyzer

matrix:
  allow_failures:
    - script: rebar3 gradualizer

cache:
  directories:
    - $HOME/.cache/rebar3


cache:
directories:
Expand Down
4 changes: 4 additions & 0 deletions rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@
{dev_mode, false},
{include_src, false}
]}.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd really need here to have a

{gradualizer_opts, [{print_file, module}]}.

Otherwise, as you can see on the current Travis build, it raises error but it doesn't say in which file, which is pretty much confusing xD

{plugins, [
{gradualizer, {git, "https://github.com/aleklisi/Gradualizer", {branch, "master"}}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'd definitely go for the original josefs repo instead of your fork, I don't know how much trouble you might have at keeping your up-to-date. They just pushed a fix for that OTP22 problem you were having 🙂

]}.
16 changes: 8 additions & 8 deletions rebar.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,34 @@
1},
{<<"bbmustache">>,{pkg,<<"bbmustache">>,<<"1.6.1">>},1},
{<<"bear">>,
{git,"git://github.com/boundary/bear.git",
{git,"https://github.com/boundary/bear.git",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, no, this one, like all the ones in this file, are I think a by-product of your computer maybe connecting to github through https and not through ssh. I don't think we need to change that.

Also, there's no new field for Gradualizer in your rebar.lock, how comes? 🤔

{ref,"119234548783af19b8ec75c879c5062676b92571"}},
4},
{<<"cowboy">>,{pkg,<<"cowboy">>,<<"2.3.0">>},1},
{<<"cowboy_swagger">>,{pkg,<<"cowboy_swagger">>,<<"2.1.0">>},1},
{<<"cowlib">>,{pkg,<<"cowlib">>,<<"2.6.0">>},2},
{<<"edown">>,
{git,"git://github.com/uwiger/edown.git",
{git,"https://github.com/uwiger/edown.git",
{ref,"b7c8eb0ac1859f8fce11cbfe3526f5ec83194776"}},
4},
{<<"escalus">>,
{git,"git://github.com/esl/escalus.git",
{git,"https://github.com/esl/escalus.git",
{ref,"5794d0abcb4838a8de32da629c49a288f3516570"}},
0},
{<<"exml">>,
{git,"https://github.com/esl/exml.git",
{ref,"a307e83669ad0a8d96ea3f2be9da36417efb94fc"}},
1},
{<<"exometer">>,
{git,"git://github.com/Feuerlabs/exometer.git",
{git,"https://github.com/Feuerlabs/exometer.git",
{ref,"7a7bd8d2b52de4d90f65aa3f6044b0e988319b9e"}},
1},
{<<"exometer_core">>,
{git,"git://github.com/Feuerlabs/exometer_core.git",
{git,"https://github.com/Feuerlabs/exometer_core.git",
{ref,"d7c4ddd066b5a56f7118bdb00dd7b22277340a35"}},
2},
{<<"folsom">>,
{git,"git://github.com/boundary/folsom",
{git,"https://github.com/boundary/folsom",
{ref,"38e2cce7c64ce1f0a3a918d90394cfc0a940b1ba"}},
3},
{<<"fusco">>,
Expand All @@ -54,15 +54,15 @@
{ref,"d0246fe143058b6404f66cf99fece3ff6e87b7ed"}},
1},
{<<"parse_trans">>,
{git,"git://github.com/uwiger/parse_trans.git",
{git,"https://github.com/uwiger/parse_trans.git",
{ref,"a210adafdfbb904d156d8f22abd5fb58fc17de1e"}},
3},
{<<"proper">>,{pkg,<<"proper">>,<<"1.3.0">>},1},
{<<"quickrand">>,{pkg,<<"quickrand">>,<<"1.7.5">>},2},
{<<"ranch">>,{pkg,<<"ranch">>,<<"1.4.0">>},2},
{<<"recon">>,{pkg,<<"recon">>,<<"2.4.0">>},1},
{<<"setup">>,
{git,"git://github.com/uwiger/setup.git",
{git,"https://github.com/uwiger/setup.git",
{ref,"85447ca5eb671db0517a475791ac7fb3604bf44d"}},
3},
{<<"trails">>,{pkg,<<"trails">>,<<"2.1.0">>},1},
Expand Down