Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut for calling user by atom #119

Open
bartekgorny opened this issue Sep 27, 2016 · 2 comments
Open

Shortcut for calling user by atom #119

bartekgorny opened this issue Sep 27, 2016 · 2 comments

Comments

@bartekgorny
Copy link
Contributor

93ee6ee deprecates calls like:

escalus_stanza:last_activity(bob)

which have to be replaced by:

BobShortJID = escalus_client:short_jid(Bob),
escalus_stanza:last_activity(BobShortJID)

To make test development easier, maybe we could consider this:

escalus_stanza:last_activity(bob, Config)
@michalwski
Copy link
Contributor

What would be the Config? Remember that escalus_stanzas module is not aware of any Config right now. I think it should remain this way.

@michalwski
Copy link
Contributor

Any comment on this @bartekgorny or can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartekgorny @michalwski