Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write rw-heatmaps tool in golang #17404

Closed
Tracked by #16467
jmhbnz opened this issue Feb 11, 2024 · 7 comments
Closed
Tracked by #16467

Re-write rw-heatmaps tool in golang #17404

jmhbnz opened this issue Feb 11, 2024 · 7 comments
Assignees
Labels
area/performance area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@jmhbnz
Copy link
Member

jmhbnz commented Feb 11, 2024

What would you like to be added?

Sub task under #16467

We currently have https://github.com/etcd-io/etcd/tree/main/tools/rw-heatmaps as a helpful custom utility for qualifying etcd performance visually.

Unfortunately the current tooling is written in python which doesn't make sense for etcd as a golang project and introduces challenges keeping the tool maintained.

There was a historic stale attempt at this rewrite #15060 however this changed the existing tool functionality so was not a simple rewrite and did not get consensus to proceed.

@ivanvc has begun work on a newer rewrite that does not introduce any new features and would give us a clear pathway forward.

Why is this needed?

We need well maintained tooling to regularly qualify the performance of etcd.

@jmhbnz
Copy link
Member Author

jmhbnz commented Feb 11, 2024

/assign @ivanvc

@k8s-ci-robot
Copy link

@jmhbnz: GitHub didn't allow me to assign the following users: ivanvc.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ivanvc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz jmhbnz added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 11, 2024
@ivanvc
Copy link
Member

ivanvc commented Feb 11, 2024

Leaving a comment so you can assign it to me, or perhaps prow will do it if I try?

@ivanvc
Copy link
Member

ivanvc commented Feb 11, 2024

/assign

@ivanvc
Copy link
Member

ivanvc commented Mar 15, 2024

Hi @jmhbnz, after reviewing today's triage meeting notes, I see this issue was discussed. As agreed in the meeting (the recording is not on YouTube yet), #15060 should be closed when I implement the line charts (hopefully soon). In my opinion, this issue can be closed now, but @ahrtr may also want to weigh in.

@ahrtr
Copy link
Member

ahrtr commented Mar 15, 2024

In my opinion, this issue can be closed now, but @ahrtr may also want to weigh in.

Closed.

@ahrtr
Copy link
Member

ahrtr commented Mar 15, 2024

OOPS, I misread the comment above, I closed the PR instead of this issue. I am good as long as eventually we can integrate the line chart. Please feel free to close this issue if you want.

@jmhbnz jmhbnz closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

No branches or pull requests

4 participants