Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): fix links and build tool list #19111

Merged
merged 1 commit into from
Dec 28, 2024
Merged

docs(contributing): fix links and build tool list #19111

merged 1 commit into from
Dec 28, 2024
+14 −5

Conversation

jverce
Copy link
Contributor

@jverce jverce commented Dec 27, 2024

Changelog

  • Fix a couple of broken links related to code styling and linting
  • Add jq and xz to the list of build tools (needed when running make verify)
  • Add links to the website of all the listed build tools

Fixes #19110

@jverce
docs(contributing): fix links and build tool list
38739fc 
* Fix a couple of broken links related to code styling and linting
* Add `jq` and `xz` to the list of build tools (needed when running
  `make verify`)
* Add links to the website of all the listed build tools

Signed-off-by: Jay Vercellone <[email protected]>
@k8s-ci-robot
Copy link

Hi @jverce. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@siyuanfoundation
Copy link
Contributor

/lgtm

Thanks @jverce!

@jmhbnz
Copy link
Member

jmhbnz commented Dec 28, 2024

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (a37bee0) to head (38739fc).
Report is 2 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19111      +/-   ##
==========================================
+ Coverage   68.79%   68.86%   +0.06%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
+ Hits        24520    24544      +24     
+ Misses       9693     9680      -13     
+ Partials     1427     1416      -11

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37bee0...38739fc. Read the comment docs.

jmhbnz
jmhbnz approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @jverce

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, jverce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 3782b67 into etcd-io:main Dec 28, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees

@siyuanfoundation siyuanfoundation

Labels
approved lgtm ok-to-test size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links and incomplete build tool list in CONTIRBUTING guide
4 participants
@jverce @k8s-ci-robot @siyuanfoundation @jmhbnz